Fix broken doc links in Configuration section #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synfinatic
reviewed
Feb 28, 2022
docs/quickstart.md
Outdated
| * Maximum number of History items to keep ([HistoryLimit](docs/config.md#historylimit)) | ||
| * Number of minutes to keep items in History ([HistoryMinutes](docs/config.md#historyminutes)) | ||
| * Log Level ([LogLevel](docs/config.md#loglevel--loglines)) | ||
| * SSO Instance Name ([DefaultSSO](./config.md#defaultsso)) |
There was a problem hiding this comment.
we can just get rid of the ./ completely right?
There was a problem hiding this comment.
ah yeah it seems so. Removed them
|
Thank you for making AWS SSO CLI better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to set up this tool I noticed the links in the Configuration section of the Quick Start guide were broken. They showed up with two
docs/parts in the path. I think they were just some typos in the relative paths.This PR corrects that issue. I confirmed that the links now work on my fork.