Remove eval and fix exec on Windows
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 43.60% 43.52% -0.09%
==========================================
Files 10 10
Lines 1525 1528 +3
==========================================
Hits 665 665
- Misses 806 808 +2
- Partials 54 55 +1
Continue to review full report at Codecov.
|
synfinatic
force-pushed
the
windows-setup
branch
from
7f3fa58 to
28180ae
Compare
- Can't use `eval` with Windows CommandPrompt/PowerShell (#188) - Default to `cmd.exe` for `exec` on Windows - Detect invalid accountId with -A flag - Improve docs for Windows in FAQ - Fully fix bogus wincred error in last PR
synfinatic
force-pushed
the
windows-setup
branch
from
28180ae to
21dfa88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evalwith Windows (Need to work around Windows is lackingevalequivalent #188)cmd.exeforexecon Windows