[Lottie Exporter] Added support for Vector X and Vector Y convert method #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging c83a422 into 15080f9 - view on LGTM.com new alerts:
|
AnishGG
reviewed
Jun 28, 2020
| self.subparams["vectory"].extract_subparams() | ||
| vector, eff_1 = self.subparams["vectory"].subparams["vector"].recur_animate("vector") | ||
| self.expression_controllers.extend(eff_1) | ||
| if self.dimension == 2: |
There was a problem hiding this comment.
I think we can write this statement as:
ret = "[{y}[1], {y}[1]]" if self.dimension == 2 else "{y}[1]"
This is more compact and removes the warnings on lgtm
There was a problem hiding this comment.
Changed the statement ^__^
AnishGG
requested changes
Jun 28, 2020
There was a problem hiding this comment.
I have tested this PR and it works perfectly. :D
Just one suggestion for code style.
Keep up the good work @saurabh-ramola ^__^
saurabh-ramola
force-pushed
the
vector_x_y_convert_method
branch
from
8ae088b to
1aae12e
Compare
AnishGG
approved these changes
Jun 28, 2020
|
Merged. Thank you! |
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Jul 8, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Jul 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Jul 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
Merged
morevnaproject
pushed a commit
that referenced
this pull request
Jul 12, 2021
- Convert methods not working with radius of simple circle layer (#1101) - [Lottie exporter] Add support for variable gamma correction (#1174) - Changes made to offsetKeyFrame file (#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (#1236 #1254 #1286 #1363 #1409 #1447 #1446 #1516 #1515 #1593 #1586 #1619 #1606 #1650 #1587) - Add support for blur layers (#1505) - Add support for Outline layer without variable widths (#1647) - Improve support for exported values (#2182) - Some code cleanup (#1199 #1213 #1226 #1456 #2061)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 9, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject
pushed a commit
to morevnaproject/synfig
that referenced
this pull request
Aug 10, 2021
- Convert methods not working with radius of simple circle layer (synfig#1101) - [Lottie exporter] Add support for variable gamma correction (synfig#1174) - Changes made to offsetKeyFrame file (synfig#1233) - Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587) - Add support for blur layers (synfig#1505) - Add support for Outline layer without variable widths (synfig#1647) - Improve support for exported values (synfig#2182) - Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Vector X and Vector Y convert method in Lottie exporter plugin.