Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lottie Exporter] Add support for aTan2 convert method #1363

Merged
merged 2 commits into from
May 21, 2020
Merged

[Lottie Exporter] Add support for aTan2 convert method #1363

merged 2 commits into from
May 21, 2020

Conversation

saurabh-ramola
Copy link
Member

@saurabh-ramola saurabh-ramola commented Apr 17, 2020 •
edited
Loading

Added aTan2 convert method for Lottie Exporter plugin.
@AnishGG , @ice0 , please review 😃

Note: aTan2 convert method works with angle-valued parameters.

@saurabh-ramola saurabh-ramola changed the title Add support for aTan2 convert method [Lottie Exporter] Add support for aTan2 convert method Apr 17, 2020
@AnishGG AnishGG self-requested a review April 18, 2020 06:20
@saurabh-ramola
Copy link
Member Author

Added support for Vector Angle convert method for Lottie Exporter plugin. This convert method is similar to aTan2 convert method.

@AnishGG , @ice0 , Please review.

AnishGG
AnishGG requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@AnishGG AnishGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have requested some changes. Always test your changes with a diverse set of examples.
Also, I will suggest to put the "vectorangle" feature in a seperate PR.

synfig-studio/plugins/lottie-exporter/common/Param.py Outdated Show resolved Hide resolved
@saurabh-ramola saurabh-ramola force-pushed the lottie_convert_methods branch 2 times, most recently from de9d062 to d980956 Compare May 13, 2020 07:51
@saurabh-ramola saurabh-ramola force-pushed the lottie_convert_methods branch from d980956 to da16d77 Compare May 19, 2020 11:30
@AnishGG
Copy link
Member

AnishGG commented May 19, 2020

@ice0 I guess this PR is ready for merge. ^__^

@ice0 ice0 merged commit 14667dd into synfig:master May 21, 2020
@ice0
Copy link
Collaborator

ice0 commented May 21, 2020

Merged. Thank you!

rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 8, 2021
@rodolforg
Update Lottie Exporter plugin
c9ed76a 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
@rodolforg
Update Lottie Exporter plugin
3aa9490 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
@rodolforg
Update Lottie Exporter plugin
2743898 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
@rodolforg rodolforg mentioned this pull request Jul 12, 2021
Merged
morevnaproject pushed a commit that referenced this pull request Jul 12, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
f212c12 
- Convert methods not working with radius of simple circle layer (#1101)
- [Lottie exporter] Add support for variable gamma correction (#1174)
- Changes made to offsetKeyFrame file (#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (#1236 #1254 #1286 #1363 #1409 #1447 #1446 #1516 #1515 #1593 #1586 #1619 #1606 #1650 #1587)
- Add support for blur layers (#1505)
- Add support for Outline layer without variable widths (#1647)
- Improve support for exported values (#2182)
- Some code cleanup (#1199 #1213 #1226 #1456 #2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
73bac78 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
a6ea98a 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 10, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
dd3adbe 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnishGG AnishGG AnishGG approved these changes

@ice0 ice0 ice0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabh-ramola @AnishGG @ice0