Add fsync after creating new manifest #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@syndtr - can you have a look/merge at this PR. |
manish-sethi
force-pushed
the
fsync_new_manifest
branch
from
c8c5f51 to
043e46e
Compare
This commit - Upgrades go versions. Build fails for prior versions as they do not use go modules - Disables go vet for the "tip" till the issues are fixed for latest go version Signed-off-by: manish <manish.sethi@gmail.com>
This simple PR adds an fsync call on the manifest file when a new manifest file is generated at the start. In absence of this, the code updates the "CURRENT" and deletes the previous manifest file and a crash at this point could leave the latest manifest with a single incomplete record. Under this situation, a restart is expected to lead to [manifest corrupt error](https://github.com/syndtr/goleveldb/blob/5c35d600f0caac04c20d52438103f1a7aa612598/leveldb/session.go#L192) This seems to explain the error observed in issue#335. We too have observed this error in our environment.
manish-sethi
force-pushed
the
fsync_new_manifest
branch
from
043e46e to
eb13543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR adds an fsync call on the manifest file when a new
manifest file is generated at the start.
In absence of this, the code updates the "CURRENT" and deletes the
previous manifest file and a crash at this point could leave the latest
manifest with a single incomplete record. With this content in the manifest file,
a restart is expected to lead to manifest corrupt error
This seems to explain the error observed in issue #335. We too have observed this error in our environment.
closes #335.