This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
Drop dependency on Composer #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
TomasVotruba
force-pushed
the
ci-fix
branch
2 times, most recently
from
2778895 to
1322d22
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
ci-fix
branch
11 times, most recently
from
7ca038c to
2ff5470
Compare
TomasVotruba
commented
Oct 25, 2020
| @@ -55,6 +55,8 @@ public function decoratePackageComposerJsonWithPackageSymlinks( | |||
| 'options' => [ | |||
| 'symlink' => false, | |||
| ], | |||
| // since composer 2.0 - see https://getcomposer.org/doc/articles/repository-priorities.md#default-behavior | |||
| 'canonical' => false, | |||
There was a problem hiding this comment.
@samsonasik In the end it took more refactoring to find the bug.
This was the line, that was one of important fixes with new Composer 2.
This behavior changed: https://getcomposer.org/doc/articles/repository-priorities.md#default-behavior
There was a problem hiding this comment.
@TomasVotruba thank you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.