remove dependency on composer

composer.json

@@ -4,7 +4,6 @@
     "license": "MIT",
     "require": {
         "php": ">=7.2",
-        "composer/composer": "^2.0",
         "composer/xdebug-handler": "^1.4",
         "erusev/parsedown": "^1.7",
         "erusev/parsedown-extra": "^0.7.1",

packages/composer-json-manipulator/composer.json

@@ -5,7 +5,6 @@
     "type": "symfony-bundle",
     "require": {
         "php": ">=7.2",
-        "composer/composer": "^2.0",
         "nette/utils": "^3.0",
         "symfony/config": "^4.4|^5.1",
         "symfony/dependency-injection": "^4.4|^5.1",

packages/composer-json-manipulator/src/Sorter/ComposerPackageSorter.php

@@ -0,0 +1,72 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\ComposerJsonManipulator\Sorter;
+
+use Nette\Utils\Strings;
+
+/**
+ * Mostly inspired by https://github.com/composer/composer/blob/master/src/Composer/Json/JsonManipulator.php
+ */
+final class ComposerPackageSorter
+{
+    /**
+     * @see https://regex101.com/r/tMrjMY/1
+     * @var string
+     */
+    private const PLATFORM_PACKAGE_REGEX = '#^(?:php(?:-64bit|-ipv6|-zts|-debug)?|hhvm|(?:ext|lib)-[a-z0-9](?:[_.-]?[a-z0-9]+)*|composer-(?:plugin|runtime)-api)$#iD';
+
+    /**
+     * @see https://regex101.com/r/SXZcfb/1
+     * @var string
+     */
+    private const REQUIREMENT_TYPE_REGEX = '#^(?<name>php|hhvm|ext|lib|\D)#';
+
+    /**
+     * Sorts packages by importance (platform packages first, then PHP dependencies) and alphabetically.
+     * @link https://getcomposer.org/doc/02-libraries.md#platform-packages
+     *
+     * @param string[] $packages
+     * @return string[]
+     */
+    public function sortPackages(array $packages = []): array
+    {
+        uksort($packages, function (string $firstPackageName, string $secondPackageName): int {
+            return $this->createRequirement($firstPackageName) <=> $this->createRequirement($secondPackageName);
+        });
+
+        return $packages;
+    }
+
+    private function createRequirement(string $requirement): string
+    {
+        if ($this->isPlatformPackage($requirement)) {
+            return (string) Strings::replace(
+                $requirement,
+                self::REQUIREMENT_TYPE_REGEX,
+                function (array $match): string {
+                    $name = $match['name'];
+                    if ($name === 'php' || $name === 'hhvm') {
+                        return '0-' . $name;
+                    }
+                    if ($name === 'ext') {
+                        return '1-' . $name;
+                    }
+                    if ($name === 'lib') {
+                        return '2-' . $name;
+                    }
+
+                    return '3-' . $name;
+                }
+            );
+        }
+
+        return '4-' . $requirement;
+    }
+
+    private function isPlatformPackage(string $name): bool
+    {
+        return (bool) Strings::match($name, self::PLATFORM_PACKAGE_REGEX);
+    }
+}

packages/composer-json-manipulator/src/ValueObject/ComposerJson.php

@@ -4,9 +4,8 @@
 
 namespace Symplify\ComposerJsonManipulator\ValueObject;
 
-use Composer\Json\JsonManipulator;
 use Nette\Utils\Arrays;
-use Symplify\PackageBuilder\Reflection\PrivatesCaller;
+use Symplify\ComposerJsonManipulator\Sorter\ComposerPackageSorter;
 use Symplify\SmartFileSystem\SmartFileInfo;
 use Symplify\SymplifyKernel\Exception\ShouldNotHappenException;
 
@@ -97,6 +96,16 @@ final class ComposerJson
      */
     private $fileInfo;
 
+    /**
+     * @var ComposerPackageSorter
+     */
+    private $composerPackageSorter;
+
+    public function __construct()
+    {
+        $this->composerPackageSorter = new ComposerPackageSorter();
+    }
+
     public function setOriginalFileInfo(SmartFileInfo $fileInfo): void
     {
         $this->fileInfo = $fileInfo;
@@ -112,9 +121,7 @@ public function setName(string $name): void
      */
     public function setRequire(array $require): void
     {
-        $require = $this->sortPackages($require);
-
-        $this->require = $require;
+        $this->require = $this->composerPackageSorter->sortPackages($require);
     }
 
     /**
@@ -135,7 +142,7 @@ public function getRequireDev(): array
 
     public function setRequireDev(array $requireDev): void
     {
-        $this->requireDev = $this->sortPackages($requireDev);
+        $this->requireDev = $this->composerPackageSorter->sortPackages($requireDev);
     }
 
     /**
@@ -505,17 +512,6 @@ private function getPsr4AndClassmapDevDirectories(): array
         return array_merge($psr4Directories, $classmapDirectories);
     }
 
-    /**
-     * @param string[] $packages
-     * @return string[]
-     */
-    private function sortPackages(array $packages): array
-    {
-        $privatesCaller = new PrivatesCaller();
-
-        return $privatesCaller->callPrivateMethodWithReference(JsonManipulator::class, 'sortPackages', $packages);
-    }
-
     private function moveValueToBack(string $valueName): void
     {
         $key = array_search($valueName, $this->orderedKeys, true);

packages/composer-json-manipulator/tests/ComposerJsonFactory/Source/some_composer.json

@@ -7,5 +7,9 @@
     },
     "autoload-dev": {
         "classmap": ["tests"]
+    },
+    "require": {
+        "php": "^7.4",
+        "symfony/console": "^5.2"
     }
 }

packages/composer-json-manipulator/tests/ComposerJsonSchemaValidation/ComposerJsonSchemaValidationTest.php

@@ -4,14 +4,12 @@
 
 namespace Symplify\ComposerJsonManipulator\Tests\ComposerJsonSchemaValidation;
 
-use Composer\Console\Application;
-use Symfony\Component\Console\Input\ArrayInput;
 use Symplify\ComposerJsonManipulator\FileSystem\JsonFileManager;
 use Symplify\ComposerJsonManipulator\Tests\HttpKernel\ComposerJsonManipulatorKernel;
 use Symplify\PackageBuilder\Tests\AbstractKernelTestCase;
 use Symplify\SmartFileSystem\SmartFileSystem;
 
-class ComposerJsonSchemaValidationTest extends AbstractKernelTestCase
+final class ComposerJsonSchemaValidationTest extends AbstractKernelTestCase
 {
     /**
      * @var JsonFileManager
@@ -49,25 +47,5 @@ public function testCheckEmptyKeysAreRemoved(): void
         $this->assertArrayHasKey('auto-scripts', $sourceJson['scripts']);
         $this->assertArrayNotHasKey('require-dev', $targetJson);
         $this->assertArrayNotHasKey('auto-scripts', $targetJson['scripts']);
-
-        /*
-         * Validate composer.json schema using `composer validate`
-         */
-        $arrayInput = new ArrayInput([
-            'command' => 'validate',
-            'file' => $targetJsonPath,
-            // https://getcomposer.org/doc/03-cli.md#validate
-            '--no-check-publish' => true,
-            '--no-interaction' => true,
-            '--quiet' => true,
-        ]);
-        $application = new Application();
-        // prevent `$application->run` method from exiting the script
-        $application->setAutoExit(false);
-        $this->assertSame(
-            0,
-            $application->run($arrayInput),
-            'Dumped composer.json did not pass validation ("composer validate --no-check-publish" exited with non-zero status)'
-        );
     }
 }

packages/monorepo-builder/composer.json

@@ -7,7 +7,6 @@
     ],
     "require": {
         "php": ">=7.2",
-        "composer/composer": "^2.0",
         "nette/utils": "^3.0",
         "jean85/pretty-package-versions": "^1.2",
         "phar-io/version": "^2.0.1|^3.0",