Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation6: Additional fixup #285

Merged
merged 13 commits into from
May 11, 2018
Merged

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented May 4, 2018

See #170.

Fixes/Changes/Improvements:

  • Improve "Please wait..." text to place it at center of display.
  • Prevent spacing between items of top bar because of inline-block rendering (See PR #170: Least fixup #187 bug 1).
  • Icons in home page are warped (See 3).
  • Consistent headings and title bars.

Known bug:

  • In environments without CSS/javascript support, redundant texts with heading (h2) and title bar are shown.

@xavierba
Copy link
Contributor

Hi @ikedas,
I tested this PR on top of foundation6 branch.
It fixes a couple glitches I've noticed in foundation6 branch.
I've navigated here and there in the various menus and everything now looks good to me.

There is only one issue left. The login tab that is a dropdown menu in the 6.2 branch is now a button in the foundation6 branch.

Regards,
Xavier

@ikedas
Copy link
Member Author

ikedas commented May 11, 2018

When page is (re)loaded, menu bar shakes itself side by side. For example in image below, brower reload is done twice (click image to show animation again).
img_0026
This indicates that CSS is poorly optimized. I don't know how to do it.

@ikedas
Copy link
Member Author

ikedas commented May 11, 2018

@xavierba,

There is only one issue left. The login tab that is a dropdown menu in the 6.2 branch is now a button in the foundation6 branch.

It needs javascript code to make dropdown not disappearing when menu item is clicked or menu is out of focus. You can revert corresponding change to know what appears without such treatment.
See also past discussions.

Anyways, javascript code for F5 is not applicable to F6, and if we need this feature (sticky dropdown menu for login form), we have to write code with new logic.

@ikedas ikedas merged commit 099d3f7 into sympa-community:foundation6 May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants