Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PmdDescriptor #45

Merged
merged 1 commit into from
Nov 17, 2014
Merged

Fix PmdDescriptor #45

merged 1 commit into from
Nov 17, 2014

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Nov 16, 2014

A PHP warning is displayed when using the PMD format on a project with no violations:

$ php insight.phar analysis d7d70442-b52c-4072-8e03-45e6a47e1ca2 --format="pmd"
PHP Warning:  Invalid argument supplied for foreach() in phar:///var/lib/jenkins/insight.phar/SensioLabs/Insight/Cli/Descriptor/PmdDescriptor.php on line 31
<?xml version="1.0" encoding="UTF-8"?>
<pmd timestamp="2014-11-16T11:15:54+01:00"/>

This PR fix this bug.

@lyrixx
Copy link
Contributor

lyrixx commented Nov 17, 2014

... and one more bug fixed, thank you @dunglas.

@lyrixx lyrixx merged commit 0339f59 into symfonycorp:master Nov 17, 2014
lyrixx added a commit that referenced this pull request Nov 17, 2014
This PR was merged into the 1.1.x-dev branch.

Discussion
----------

Fix PmdDescriptor

A PHP warning is displayed when using the PMD format on a project with no violations:
```xml
$ php insight.phar analysis d7d70442-b52c-4072-8e03-45e6a47e1ca2 --format="pmd"
PHP Warning:  Invalid argument supplied for foreach() in phar:///var/lib/jenkins/insight.phar/SensioLabs/Insight/Cli/Descriptor/PmdDescriptor.php on line 31
<?xml version="1.0" encoding="UTF-8"?>
<pmd timestamp="2014-11-16T11:15:54+01:00"/>
```

This PR fix this bug.

Commits
-------

0339f59 Fix PmdDescriptor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants