Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation] Fix CSV escape char in CsvFileLoader on PHP >= 7.4 #57828

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[Translation] Fix CSV escape char in CsvFileLoader on PHP >= 7.4 #57828

merged 1 commit into from
Jul 26, 2024

Conversation

alexandre-daubois
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Related to #57827. This check has already been done in other places like:

symfony/src/Symfony/Component/DependencyInjection/EnvVarProcessor.php

Line 310 in 4a176ce

return str_getcsv($env, ',', '"', \PHP_VERSION_ID >= 70400 ? '' : '\\');

@carsonbot

This comment has been minimized.

Sign in to view
@carsonbot carsonbot added this to the 7.2 milestone Jul 25, 2024
@alexandre-daubois alexandre-daubois changed the base branch from 7.2 to 5.4 July 25, 2024 09:59
@derrabus derrabus modified the milestones: 7.2, 5.4 Jul 25, 2024
xabbuh
xabbuh requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to do something about cases where setCsvControl() is never called (see the failing tests)

@alexandre-daubois alexandre-daubois force-pushed the csv-escape branch 2 times, most recently from ba3accb to 482b9d7 Compare July 26, 2024 12:09
@alexandre-daubois
Copy link
Contributor Author

Indeed. All green now 👍

@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 31e3abf into symfony:5.4 Jul 26, 2024
11 of 12 checks passed
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Jul 27, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh xabbuh approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

Assignees
No one assigned
Labels
Status: Reviewed Translation
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-daubois @carsonbot @nicolas-grekas @xabbuh @derrabus