[PropertyInfo] Handle collection in PhpStan same as PhpDoc #57617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
I am not completely convinced that allowing subclasses in #52699 was a good decision as it rather looks like introducing a new feature in a patch release. But now that we did it for the PhpDocTypeHelper updating the PhpStanTypeHelper in the same way looks reasonable to me.
chalasr
approved these changes
Jul 4, 2024
src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpDocExtractorTest.php
Outdated
Show resolved
Hide resolved
mtarld
force-pushed
the
fix/property-info-phpstan-collection
branch
from
80a81f6
to
f098683
Compare
|
Thank you @mtarld. |
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jul 9, 2024
This change ensures that the tests that have been added in symfony#57617 are also applied when the types from the TypeInfo component are used instead of the Type class that is built into the PropertyInfo component.
fabpot
added a commit
that referenced
this pull request
Jul 10, 2024
This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] add tests for TypeInfo types | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT This change ensures that the tests that have been added in #57617 are also applied when the types from the TypeInfo component are used instead of the Type class that is built into the PropertyInfo component. Commits ------- 93d3209 add tests for TypeInfo types
This was referenced Jul 26, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #52699, a comment suggested to support classes that inherit from collection classes (such as doctrine collections for example).
This has been done for PHPDoc, but not in PHPStan.
This PR adds this missing behavior to PHPStan (and adds the missing PHPDoc related test).