Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem leak in example doctrine testing #6391

Merged
merged 1 commit into from
May 21, 2016
Merged

Fix mem leak in example doctrine testing #6391

merged 1 commit into from
May 21, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets symfony/symfony#18236

@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Mar 21, 2016

What about adding a comment that explains why we set it to null here? People might wonder otherwise what's the reason for this statement is.

@weaverryan
Copy link
Member

👍 Note would be cool - I'm fine either way

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

We can add the note while merging.

@wouterj wouterj merged commit 7be63a4 into symfony:2.3 May 21, 2016
wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
minor #6391 Fix mem leak in example doctrine testing (nicolas-grekas)
5e20cd0 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix mem leak in example doctrine testing

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | symfony/symfony#18236

Commits
-------

7be63a4 Fix mem leak in example doctrine testing
wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
[#6391] Add small explanation
4186c32
@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thanks! This is now merged. I've added a very minor comment in 4186c32 to explain that this is not a redundant line of code.

@nicolas-grekas nicolas-grekas deleted the doctrine-clean branch July 24, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @javiereguiluz @xabbuh @weaverryan @wouterj