[create_framework] Add missing extract() 2nd arg

[kenjis]

See previous page: http://symfony.com/doc/2.3/create_framework/templating.html

The code is extract($request->attributes->all(), EXTR_SKIP);.

In this page, suddenly EXTR_SKIP is missing. I don't know why.

[javiereguiluz]

@kenjis 👍 thanks for reporting this error.

I can confirm this is an error. In the original article at Fabien's website, the EXTR_SKIP argument was present:

[xabbuh]

@javiereguiluz The page that @kenjis changed is actual part 6, but I agree that it should be fixed here (using extract() might generally not be the best idea though).

[xabbuh]

Hm, actually I think it's right to not specify an argument here. The reason this was done in the previos chapters is that the default behaviour of extract() is to overwrite any existing variables with the same name. However, this is not a good idea in the global context as we might lose our very own framework variables. But this isn't issue anymore in the present code as the extract() call is wrapped in the render_template() function.

[kenjis]

@xabbuh the extract() has moved into a function on prev page: http://symfony.com/doc/2.3/create_framework/templating.html
So if we remove EXTR_SKIP, we should do on prev page and add why.

[xabbuh]

@kenjis Yeah, I agree that it should simply be removed on the previous page.

[wouterj]

Hi @kenjis! Thanks for the original fix and the discussion that came with it. As we concluded that the better fix would be to remove the argument from the templating guide, I've taken your commit and changed it so it can be merged: #5568

So I'm closing this PR, but you still get all the credits!

[wouterj]

Good news! We decided to add this argument to the other examples again, as it prevents overriding the $request variable. So it makes perfectly sense to merge this PR now. Thank you for creating it.

[kenjis]

My pleasure.