[load_balancer_reverse_proxy ] Always use 127.0.0.1 as a trusted proxy #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the behaviour changed in Symfony 2.7. Before, the solution just worked perfectly with a Amazon ELB. After upgrading to Symfony 2.7 the subrequests weren't trusted anymore because they set the `REMOTE_ADDR` to `127.0.0.1`
|
I guess that is related to the security fix described in http://symfony.com/blog/cve-2015-2309-unsafe-methods-in-the-request-class, isn't it? Then it must be merged into the |
|
Thank you Ruud! I'm sorry for the big delay on merging this, but I think it's a valid change. I've merged it into the 2.3 docs, as proposed by @xabbuh. |
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
…usted proxy (ruudk) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5513). Discussion ---------- [load_balancer_reverse_proxy ] Always use 127.0.0.1 as a trusted proxy Apparently the behaviour changed in Symfony 2.7. Before, the solution just worked perfectly with a Amazon ELB. After upgrading to Symfony 2.7 the subrequests weren't trusted anymore because they set the `REMOTE_ADDR` to `127.0.0.1` Commits ------- 9b2c9f4 Always use 127.0.0.1 as a trusted proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the behaviour changed in Symfony 2.7. Before, the solution just worked perfectly with a Amazon ELB. After upgrading to Symfony 2.7 the subrequests weren't trusted anymore because they set the
REMOTE_ADDRto127.0.0.1