[Components][Form] Grammar improvement #4326
Conversation
|
"each" and "every" can be used in cases like this afaik. Let's see how our natives think about it |
|
@wouterj Yes, but then you have to omit "the". |
|
@xabbuh Yep. So basically it would be:
|
|
@fabschurt I'm in favor of the last option. Can you please update this PR? |
|
@wouterj Done ;-) I did a |
|
👍 Nice change. @fabschurt Squashing commits is not necessary, but we are happy if you do it anyway. :) |
| @@ -173,7 +173,7 @@ line to your ``composer.json`` file: | |||
| } | |||
|
|
|||
| The TwigBridge integration provides you with several :doc:`Twig Functions </reference/forms/twig_reference>` | |||
| that help you render each the HTML widget, label and error for each field | |||
| that help you render each HTML widget, label and error for each field | |||
There was a problem hiding this comment.
You're right that it was wrong before, but now it's still a bit odd - we have each HTML... for each field. What would be perfect is actually removing the first each and leaving the:
that help you render the HTML widget, label and error for each field
Thanks for your attention to this! It definitely sounds plain wrong the way it is currently :).
There was a problem hiding this comment.
Oh, my fault. He did it this way and I suggested something wrong, I missed the second for each somehow...
I think the "each the" form is not correct in English, as "each" must generally be used as in "each one of", or "each of".
|
Heh heh, this kind of things is trickier than it sounds :-) I updated the PR, we should be good to go now. |
|
Thanks for you patience, Fabien! The docs got a bit better after this PR :) |
This PR was merged into the 2.3 branch. Discussion ---------- [Components][Form] Grammar improvement | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a I think the "each the" form is not correct in English, as "each" must generally be used as in "each one of", or "each of", forms that should not be used here either as the countable aspect is already expressed by "each field" further in the phrase anyway. Commits ------- cefddae Apply a grammatical improvement
I think the "each the" form is not correct in English, as "each" must
generally be used as in "each one of", or "each of", forms that should
not be used here either as the countable aspect is already expressed
by "each field" further in the phrase anyway.