Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component][EventDispatcher] documentation for the TraceableEventDispatcher #3916

Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 7, 2014

Q A
Doc fix? no
New docs? yes
Applies to 2.3, 2.4
Fixed tickets #3879

After this has been merged, the document has to be updated for Symfony 2.5 and higher to reflect that the TraceableEventDispatcher is now part of the EventDispatcher component.

@weaverryan weaverryan mentioned this pull request Jun 10, 2014
2 tasks
@weaverryan
Copy link
Member

Awesome! And even though I'm sure you'll do it immediately, I've added a note to #3879 that we need to make the 2.5 changes you mentioned. I'll merge all the way up to master right now. Thanks!

@weaverryan weaverryan merged commit 1160f7c into symfony:2.3 Jun 10, 2014
weaverryan added a commit that referenced this pull request Jun 10, 2014
…eableEventDispatcher (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Component][EventDispatcher] documentation for the TraceableEventDispatcher

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3, 2.4
| Fixed tickets | #3879

After this has been merged, the document has to be updated for Symfony 2.5 and higher to reflect that the ``TraceableEventDispatcher`` is now part of the EventDispatcher component.

Commits
-------

1160f7c add documentation for the TraceableEventDispatcher class
@xabbuh xabbuh deleted the issue-3879-traceable-event-dispatcher branch June 10, 2014 22:12
@xabbuh
Copy link
Member Author

xabbuh commented Jun 10, 2014

Thanks @weaverryan. See #3931 for the follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants