Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Change the Default Command in the Console component #3426

Merged
merged 9 commits into from
Jan 9, 2014
117 changes: 117 additions & 0 deletions components/console/changing_default_behavior.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
.. index::
single: Console; Changing the Default Behavior

Changing the Default Behavior
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title does not describe what the doc is about (default behavior of what ? Any doc about extending a part of Symfony could use this title)

=============================

.. versionadded:: 2.5,
The :method:`Symfony\\Component\\Console\\Application::setDefaultCommand`
method was introduced in version 2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does aply to the section started on line 16, not to the hole article, does it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes true! will move it to the right section


When building a command line tool, you may need to customize it to fit your needs.
Probably you want to change the Default Command that the Application runs or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default command (lowercased)

maybe you just want to run a Single Command instead of have to pass the command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single command (lowercased)

name each time. Fortunately it is possible to do both.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma after Fortunately I think


Changing the Default Command
----------------------------

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing .. version-added:: 2.5, saying "The setDefaultCommand method was introduced in Symfony 2.5."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add it 👍

By default the Application will always run the ListCommand. In order to change
the default command you just need to pass the command name you want to run by
default to the :method:`Symfony\\Component\\Console\\Application::setDefaultCommand`
method::

#!/usr/bin/env php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also not sure if the bang comment is used before in the docs, if not I prefer to remove it for consistency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from the official documentation, more specific the introduction part of the Console Component

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then we keep this.

<?php
// application.php

use Acme\Command\GreetCommand;
use Symfony\Component\Console\Application;

$command = new GreetCommand();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does it come from? When I read this document, I might not know about this command described in another part of the documentation. And anyway, this command won't work as a default command, which cannot have any argument... which is a "limitation" that should be explained in this doc.

$application = new Application();
$application->add($command);
$application->setDefaultCommand($command->getName());
$application->run()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ;


Test the new console command by running the following

.. code-block:: bash

$ app/console Fabien
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't work as we are talking about replacing the default command, when there are no argument.


This will print the following to the command line:

.. code-block:: text

Hello Fabien

Building a Single Command Application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should stay in a separate page, as it is a totally separate feature than changing the default command

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think the best solution is to keep it in its original location. It may be referenced from the page about changing the default command, to wanT than changing the default is not the best way if you only want 1 command, but it should not be in the same page IMO. It makes it harder to find the feature

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @stof

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, and it would also solve the redirect_map problem I think :)

-------------------------------------

When building a command line tool, you may not need to provide several commands.
In such case, having to pass the command name each time is tedious. Fortunately,
it is possible to remove this need by extending the application::

namespace Acme\Tool;

use Symfony\Component\Console\Application;
use Symfony\Component\Console\Input\InputInterface;

class MyApplication extends Application
{
/**
* Gets the name of the command based on input.
*
* @param InputInterface $input The input interface
*
* @return string The command name
*/
protected function getCommandName(InputInterface $input)
{
// This should return the name of your command.
return 'my_command';
}

/**
* Gets the default commands that should always be available.
*
* @return array An array of default Command instances
*/
protected function getDefaultCommands()
{
// Keep the core default commands to have the HelpCommand
// which is used when using the --help option
$defaultCommands = parent::getDefaultCommands();

$defaultCommands[] = new MyCommand();

return $defaultCommands;
}

/**
* Overridden so that the application doesn't expect the command
* name to be the first argument.
*/
public function getDefinition()
{
$inputDefinition = parent::getDefinition();
// clear out the normal first argument, which is the command name
$inputDefinition->setArguments();

return $inputDefinition;
}
}

When calling your console script, the command ``MyCommand`` will then always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] the MyCommand command [...]

be used, without having to pass its name.

You can also simplify how you execute the application::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] how to execute [...]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better is "Executing the application can also be simplified::" imo


#!/usr/bin/env php
<?php
// command.php
use Acme\Tool\MyApplication;

$application = new MyApplication();
$application->run();
2 changes: 1 addition & 1 deletion components/console/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ Console

introduction
usage
single_command_tool
changing_default_behavior
events
helpers/index
70 changes: 1 addition & 69 deletions components/console/single_command_tool.rst
Original file line number Diff line number Diff line change
@@ -1,72 +1,4 @@
.. index::
single: Console; Single command application

Building a Single Command Application
=====================================

When building a command line tool, you may not need to provide several commands.
In such case, having to pass the command name each time is tedious. Fortunately,
it is possible to remove this need by extending the application::

namespace Acme\Tool;

use Symfony\Component\Console\Application;
use Symfony\Component\Console\Input\InputInterface;

class MyApplication extends Application
{
/**
* Gets the name of the command based on input.
*
* @param InputInterface $input The input interface
*
* @return string The command name
*/
protected function getCommandName(InputInterface $input)
{
// This should return the name of your command.
return 'my_command';
}

/**
* Gets the default commands that should always be available.
*
* @return array An array of default Command instances
*/
protected function getDefaultCommands()
{
// Keep the core default commands to have the HelpCommand
// which is used when using the --help option
$defaultCommands = parent::getDefaultCommands();

$defaultCommands[] = new MyCommand();

return $defaultCommands;
}

/**
* Overridden so that the application doesn't expect the command
* name to be the first argument.
*/
public function getDefinition()
{
$inputDefinition = parent::getDefinition();
// clear out the normal first argument, which is the command name
$inputDefinition->setArguments();

return $inputDefinition;
}
}

When calling your console script, the command ``MyCommand`` will then always
be used, without having to pass its name.

You can also simplify how you execute the application::

#!/usr/bin/env php
<?php
// command.php
use Acme\Tool\MyApplication;

$application = new MyApplication();
$application->run();
This Document was moved to :doc:`/components/console/changing_default_behaviour`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have map for moved document that you should use instead (see redirection_map).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it now possible to have different redirection maps per branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot the problem is that the redirection_map is version specific, that's why I asked @danielcsgomes to do it this way.