Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WCM] Documentation for setProcessPipes() #3303

Closed
wants to merge 2 commits into from
Closed

Conversation

vektah
Copy link

@vektah vektah commented Dec 9, 2013

Q A
Doc fix? no
New docs? yes (symfony/symfony#9726 )
Applies to 2.5+
Fixed tickets -

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.4
| Fixed tickets | 9007
vektah pushed a commit to vektah/symfony that referenced this pull request Dec 9, 2013
Currently processes that output large amounts of data will block. If
the output is not important then this becomes an issue. It can be worked
around by redirecting the output to > /dev/null but this requires an
instance of /bin/sh to do the work.

This patch adds the ability to set the processPipes, and a new
processPipe that redirects to /dev/null.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#9007
| License       | MIT
| Doc PR        | symfony/symfony-docs#3303
@wouterj
Copy link
Member

wouterj commented Dec 9, 2013

FYI, I added [WCM] to your title, which means Waiting Code Merge.

@@ -257,6 +257,24 @@ When running a program asynchronously, you can send it posix signals with the
POSIX signals are not available on Windows platforms, please refer to the
`PHP documentation`_ for available signals.

Redirecting output to /dev/null
------------------------------
.. versionadded:: 2.4The ``setProcessPipes`` method was added in Symfony 2.4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have an empty line before this and the text should go on a new line indented by 4 spaces.

Also, this is never going to be in 2.4 as it is already released and no more features will be added in the the 2.4.* serie.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and can you use an API link? (also note using "was introduced in")

The :method:`Symfony\\Component\\Process\\Process::setProcessPipes` method was introduced
in Symfony 2.4.

@wouterj
Copy link
Member

wouterj commented May 21, 2014

Closing as upstream PR was closed in favor of symfony/symfony#10425, which is documented in #3664

@wouterj wouterj closed this May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants