Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 3 docs states PHP minimum version is 5.3 while composer requirement is 5.5 #5947

Closed
felipsmartins opened this issue Dec 3, 2015 · 1 comment
Closed

Symfony 3 docs states PHP minimum version is 5.3 while composer requirement is 5.5 #5947

felipsmartins opened this issue Dec 3, 2015 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@felipsmartins
Copy link

Reading symfony 3 docs, in Requirements for Running Symfony page, it's possible to see the minimum php version required is is 5.3, while composer defines php >= 5.5 as minimum requirement, see:

sf3-composer-

In docs:

sf3-req-docs

It seems that there is some inconsistency, right?
it strikes me that Symfony docs needs some update.
@felipsmartins felipsmartins changed the title Symfony 3 doc states PHP minimum version is 5.3 Symfony 3 docs states PHP minimum version is 5.3 while composer requirement is 5.5 Dec 3, 2015
@ogizanagi ogizanagi mentioned this issue Dec 3, 2015
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 4, 2015
wouterj added a commit that referenced this issue Dec 5, 2015
@wouterj
feature #5948 Update 3.0 docs accordingly to min PHP version requirem…
7a64f05 
…ent (ogizanagi)

This PR was merged into the 3.0 branch.

Discussion
----------

Update 3.0 docs accordingly to min PHP version requirement

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 3.0+
| Fixed tickets | #5947

I'm not sure about the politic regarding the removal of anything mentioning earlier version of PHP for the 3.0 docs ? Should it be reverted ?
Regarding this PR: #5585, it's seems coherent to me to do the same for PHP versions.

Commits
-------

d577848 Update docs accordingly to min PHP version requirement
@wouterj
Copy link
Member

wouterj commented Dec 5, 2015

This has now been fixed by #5948. Thanks for such a detailed issue @felipsmartins!

@wouterj wouterj closed this as completed Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felipsmartins @wouterj @xabbuh