Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable routing load in friendsofsymfony/rest-bundle:^3 #1493

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Disable routing load in friendsofsymfony/rest-bundle:^3 #1493

merged 1 commit into from
Mar 13, 2023

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Mar 13, 2023

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) March 13, 2023 17:05
@github-actions
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1493/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1493/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'friendsofsymfony/rest-bundle:^3.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

friendsofsymfony/rest-bundle

2.2 vs 3.0
diff --git a/friendsofsymfony/rest-bundle/2.2/config/packages/fos_rest.yaml b/friendsofsymfony/rest-bundle/3.0/config/packages/fos_rest.yaml
index 4cf06f56..f4e7eb66 100644
--- a/friendsofsymfony/rest-bundle/2.2/config/packages/fos_rest.yaml
+++ b/friendsofsymfony/rest-bundle/3.0/config/packages/fos_rest.yaml
@@ -1,8 +1,8 @@
-# Read the documentation: https://symfony.com/doc/master/bundles/FOSRestBundle/index.html
-#fos_rest:
+# Read the documentation: https://fosrestbundle.readthedocs.io/en/3.x/
+fos_rest:
 #    param_fetcher_listener:  true
 #    allowed_methods_listener:  true
-#    routing_loader: true
+    routing_loader: false
 #    view:
 #        view_response_listener:  true
 #    exception:

@symfony-recipes-bot symfony-recipes-bot merged commit 3080481 into symfony:main Mar 13, 2023
@W0rma W0rma deleted the disable-routing-loader-fos-rest-bundle-3 branch March 14, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants