[make:controller] avoid require doctrine/annotation when can use attributes

[Jibbarth]

Hi makers 👋 !

This PR allows to make controller when we can use PHP8 attributes without forcing to install doctrine/annotation

But we should be aware that currently, without doctrine/annotation, we don't have a nice flex recipe that enable routing annotation read on Controller folder.

See symfony/recipes#916 for reference.

So maybe we should create the config/routes/annotation.yaml in case we can use attributes AND file does not exist ? WDYT ?

[Jibbarth]

This is heavily inspired on https://github.com/symfony/maker-bundle/blob/main/src/Generator.php#L40, tell me if it's not needed in this case

[dunglas]

I'm not sure if it is worth it. When maker-bundle will require PHP 8 as a minimum version, we'll most likely drop the dependency to PhpCompatUtil, so in my opinion it's not useful to make this dependency mandatory.

[jrushlow]

No need for the deprecation here. PhpCompatUtil is internal & MakeController is final - I don't see a use case where someone would use a version >=1.31 and not be able to initiate MakeController w/o the utility.

[Jibbarth]

Deprecation removed 👌

[jrushlow]

Thanks @Jibbarth This PR will have to wait for the resolution of symfony/recipes#916 before it can be merged.

So maybe we should create the config/routes/annotation.yaml in case we can use attributes AND file does not exist ? WDYT ?

I'm not a fan of this idea. That responsibility falls on recipes / flex in my opinion.

[jrushlow]

No need for the deprecation here. PhpCompatUtil is internal & MakeController is final - I don't see a use case where someone would use a version >=1.31 and not be able to initiate MakeController w/o the utility.

[jrushlow]

Thank you @Jibbarth! we can finally get this merged in!

[jrushlow]

Note: To preserve BC, doctrine/annotations is still required for Symfony 5.4 IF the MakeController::class is used w/o passing an instance of PhpCompatUtil::class via the constructor.