Use prefix "is" for getters on boolean fields

[MaximePinot]

This is subject to discussion as there is no standard about this in the PHP world. There is a "Methods and Functions" section in PSR-12 but nothing specific to getters and setters. However, I believe this is a widely used naming convention...

[weaverryan]

Hey @MaximePinot!

In general, I like this idea. The question is, will it integrate with the other parts of Symfony - Twig (product.published), serializer & form component. And I all of these do support issers. So, I think we can totally do this :).

Could you write a test for this in ClassSourceManipulatorTest?

[MaximePinot]

Hi @weaverryan,

I'm glad you like the idea!

I added a unit test for this change.

[MaximePinot]

Hi,

The Travis CI build failed, but it has nothing to do with my changes. Almost all other opened pull requests encounter the same issue...

Is this pull request ready to be merged? @stof, do you approve these changes? :)

[romaricdrigon]

That's correct regarding tests, even master is red. We will be looking into that next Saturday, and I hope after that we can move forward all blocked PRs.

[BatsaxIV]

Hi,

This looks good, I think than you can rebase to master @MaximePinot and @weaverryan this can probably be merged WDYT?

[MaximePinot]

Hi @BatsaxIV, thanks a lot for your feedback!

I rebased to master and all checks have passed! (cc @weaverryan)

[MaximePinot]

Friendly ping @weaverryan and @stof. One year later, is this PR still relevant?

(The branch was updated from main and the test that I added passed. The two failing checks are not related to this PR. They are also failing on main.)

[jrushlow]

Thank you @MaximePinot!