Leverage symfony-tools/fabbot

.github/workflows/fabbot.yml

@@ -0,0 +1,14 @@
+name: CS
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  call-fabbot:
+    name: Fabbot
+    uses: symfony-tools/fabbot/.github/workflows/fabbot.yml@main
+    with:
+      package: MakerBundle

src/Maker/MakeMigration.php

@@ -114,7 +114,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
         try {
             $returnCode = $generateMigrationCommand->run($generateMigrationCommandInput, $commandOutput);
 
-            // non-zero code would ideally mean the internal command has already printed an errror
+            // non-zero code would ideally mean the internal command has already printed an error
             // this happens if you "decline" generating a migration when you already
             // have some available
             if (0 !== $returnCode) {

tests/Command/MakerCommandTest.php

@@ -23,7 +23,7 @@
 
 class MakerCommandTest extends TestCase
 {
-    public function testExceptionOnMissingDependencies(): void
+    public function testExceptionOnMissingDependencies()
     {
         $this->expectException(RuntimeCommandException::class);
         if (method_exists($this, 'expectExceptionMessageMatches')) {
@@ -47,7 +47,7 @@
         $tester->execute([]);
     }
 
-    public function testExceptionOnUnknownRootNamespace(): void
+    public function testExceptionOnUnknownRootNamespace()
     {
         $maker = $this->createMock(MakerInterface::class);
 

tests/Docker/DatabaseServicesTest.php

@@ -20,7 +20,7 @@
  */
 final class DatabaseServicesTest extends TestCase
 {
-    public function testExceptionThrownWithInvalidDatabaseProvided(): void
+    public function testExceptionThrownWithInvalidDatabaseProvided()
     {
         $this->expectException(RuntimeCommandException::class);
         $this->expectExceptionMessage('foo is not a valid / supported docker database type.');
@@ -38,7 +38,7 @@
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testSkeletonReturnArrayForDesiredDatabase(string $databaseName): void
+    public function testSkeletonReturnArrayForDesiredDatabase(string $databaseName)
     {
         $result = DockerDatabaseServices::getDatabaseSkeleton($databaseName, 'latest');
 
@@ -49,7 +49,7 @@
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testGetDefaultPorts(string $databaseName): void
+    public function testGetDefaultPorts(string $databaseName)
     {
         $result = DockerDatabaseServices::getDefaultPorts($databaseName);
 
@@ -59,7 +59,7 @@
     /**
      * @dataProvider mixedNameDataProvider
      */
-    public function testSuggestedVersion(string $databaseName): void
+    public function testSuggestedVersion(string $databaseName)
     {
         $result = DockerDatabaseServices::getSuggestedServiceVersion($databaseName);
 

tests/Doctrine/EntityRegeneratorTest.php

@@ -37,7 +37,7 @@ class EntityRegeneratorTest extends TestCase
     /**
      * @dataProvider getRegenerateEntitiesTests
      */
-    public function testRegenerateEntities(string $expectedDirName, bool $overwrite): void
+    public function testRegenerateEntities(string $expectedDirName, bool $overwrite)
     {
         $kernel = new TestEntityRegeneratorKernel('dev', true);
         $this->doTestRegeneration(

tests/FileManagerTest.php

@@ -188,7 +188,7 @@ public function getPathForTemplateTests()
         ];
     }
 
-    public function testWithMakerFileLinkFormatter(): void
+    public function testWithMakerFileLinkFormatter()
     {
         if (getenv('MAKER_DISABLE_FILE_LINKS')) {
             $this->markTestSkipped();

tests/GeneratorTest.php

@@ -20,7 +20,7 @@ class GeneratorTest extends TestCase
     /**
      * @dataProvider getClassNameDetailsTests
      */
-    public function testCreateClassNameDetails(string $name, string $prefix, string $suffix, string $expectedFullClassName, string $expectedRelativeClassName): void
+    public function testCreateClassNameDetails(string $name, string $prefix, string $suffix, string $expectedFullClassName, string $expectedRelativeClassName)
     {
         $fileManager = $this->createMock(FileManager::class);
         $fileManager->expects($this->any())

tests/Maker/FunctionalTest.php

@@ -24,7 +24,7 @@
      * Smoke test to make sure the DI autowiring works and all makers
      * are registered and have the correct arguments.
      */
-    public function testWiring(): void
+    public function testWiring()
     {
         $kernel = new MakerTestKernel('dev', true);
 

tests/RegexTest.php

@@ -26,7 +26,7 @@
 class RegexTest extends TestCase
 {
     /** @dataProvider generatedFilesRegexDataProvider */
-    public function testMakerTestEnvironmentGeneratedFilesRegex(string $subjectData, array $expectedResult): void
+    public function testMakerTestEnvironmentGeneratedFilesRegex(string $subjectData, array $expectedResult)
     {
         $result = [];
 
@@ -69,7 +69,7 @@ private function generatedFilesRegexDataProvider(): \Generator
     }
 
     /** @dataProvider webhookNameRegexDataProvider */
-    public function testWebhookNameRegex(string $subjectData, bool $expectedResult): void
+    public function testWebhookNameRegex(string $subjectData, bool $expectedResult)
     {
         $result = preg_match(MakeWebhook::WEBHOOK_NAME_PATTERN, $subjectData);
 

tests/Security/InteractiveSecurityHelperTest.php

@@ -209,7 +209,7 @@ public function guessEmailFieldTest()
     }
 
     /** @dataProvider authenticatorClassProvider */
-    public function testGetAuthenticatorsFromConfig(array $firewalls, array $expectedResults): void
+    public function testGetAuthenticatorsFromConfig(array $firewalls, array $expectedResults)
     {
         $helper = new InteractiveSecurityHelper();
         $result = $helper->getAuthenticatorsFromConfig($firewalls);

tests/Security/SecurityConfigUpdaterTest.php

@@ -29,7 +29,7 @@ class SecurityConfigUpdaterTest extends TestCase
     /**
      * @dataProvider getUserClassTests
      */
-    public function testUpdateForUserClass(UserClassConfiguration $userConfig, string $expectedSourceFilename, string $startingSourceFilename = 'simple_security.yaml'): void
+    public function testUpdateForUserClass(UserClassConfiguration $userConfig, string $expectedSourceFilename, string $startingSourceFilename = 'simple_security.yaml')
     {
         $this->createLogger();
 
@@ -104,7 +104,7 @@ public function getUserClassTests(): \Generator
     /**
      * @dataProvider getAuthenticatorTests
      */
-    public function testUpdateForAuthenticator(string $firewallName, $entryPoint, string $expectedSourceFilename, string $startingSourceFilename, bool $logoutSetup, bool $supportRememberMe, bool $alwaysRememberMe): void
+    public function testUpdateForAuthenticator(string $firewallName, $entryPoint, string $expectedSourceFilename, string $startingSourceFilename, bool $logoutSetup, bool $supportRememberMe, bool $alwaysRememberMe)
     {
         $this->createLogger();
 
@@ -199,7 +199,7 @@ public function getAuthenticatorTests(): \Generator
         ];
     }
 
-    public function testUpdateForFormLogin(): void
+    public function testUpdateForFormLogin()
     {
         $this->createLogger();
 
@@ -214,7 +214,7 @@ public function testUpdateForFormLogin(): void
         );
     }
 
-    public function testUpdateForJsonLogin(): void
+    public function testUpdateForJsonLogin()
     {
         $this->createLogger();
 
@@ -229,7 +229,7 @@ public function testUpdateForJsonLogin(): void
         );
     }
 
-    public function testUpdateForLogout(): void
+    public function testUpdateForLogout()
     {
         $this->createLogger();
 

tests/Security/SecurityControllerBuilderTest.php

@@ -19,23 +19,23 @@ class SecurityControllerBuilderTest extends TestCase
 {
     private string $expectedBasePath = __DIR__.'/fixtures/expected';
 
-    public function testLoginMethod(): void
+    public function testLoginMethod()
     {
         $this->runMethodTest(
             'addLoginMethod',
             \sprintf('%s/%s', $this->expectedBasePath, 'SecurityController_login.php')
         );
     }
 
-    public function testLogoutMethod(): void
+    public function testLogoutMethod()
     {
         $this->runMethodTest(
             'addLogoutMethod',
             \sprintf('%s/%s', $this->expectedBasePath, 'SecurityController_logout.php')
         );
     }
 
-    public function testLoginAndLogoutMethod(): void
+    public function testLoginAndLogoutMethod()
     {
         $builder = new SecurityControllerBuilder();
         $csm = $this->getClassSourceManipulator();

tests/Security/UserClassBuilderTest.php

@@ -23,7 +23,7 @@ class UserClassBuilderTest extends TestCase
     /**
      * @dataProvider getUserInterfaceTests
      */
-    public function testAddUserInterfaceImplementation(UserClassConfiguration $userClassConfig, string $expectedFilename): void
+    public function testAddUserInterfaceImplementation(UserClassConfiguration $userClassConfig, string $expectedFilename)
     {
         $manipulator = $this->getClassSourceManipulator($userClassConfig);
 

tests/Test/MakerTestDetailsTest.php

@@ -25,7 +25,7 @@
 
 class MakerTestDetailsTest extends TestCase
 {
-    public function testAddExtraDependencies(): void
+    public function testAddExtraDependencies()
     {
         $details = new MakerTestDetails($this->createMock(MakerInterface::class));
 
@@ -38,7 +38,7 @@ public function testAddExtraDependencies(): void
         self::assertSame(['twig', 'ux', 'mercure'], $details->getExtraDependencies());
     }
 
-    public function testAddRequiredPackageVersions(): void
+    public function testAddRequiredPackageVersions()
     {
         $details = new MakerTestDetails($this->createMock(MakerInterface::class));
 
@@ -53,7 +53,7 @@ public function testAddRequiredPackageVersions(): void
         ], $details->getRequiredPackageVersions());
     }
 
-    public function testGetDependencies(): void
+    public function testGetDependencies()
     {
         $details = new MakerTestDetails(new TestMakerFixture());
 

tests/Util/ClassDetailsTest.php

@@ -20,7 +20,7 @@
  */
 final class ClassDetailsTest extends TestCase
 {
-    public function testHasAttribute(): void
+    public function testHasAttribute()
     {
         self::assertTrue((new ClassDetails(FixtureClassDetails::class))->hasAttribute(UniqueEntity::class));
 

tests/Util/ClassSource/ClassDataTest.php

@@ -18,7 +18,7 @@
 
 class ClassDataTest extends TestCase
 {
-    public function testStaticConstructor(): void
+    public function testStaticConstructor()
     {
         $meta = ClassData::create(MakerBundle::class);
 
@@ -30,14 +30,14 @@ public function testStaticConstructor(): void
         self::assertSame('App\Symfony\Bundle\MakerBundle\MakerBundle', $meta->getFullClassName());
     }
 
-    public function testGetClassDeclaration(): void
+    public function testGetClassDeclaration()
     {
         $meta = ClassData::create(MakerBundle::class);
 
         self::assertSame('final class MakerBundle', $meta->getClassDeclaration());
     }
 
-    public function testIsFinal(): void
+    public function testIsFinal()
     {
         $meta = ClassData::create(MakerBundle::class);
 
@@ -49,15 +49,15 @@ public function testIsFinal(): void
         self::assertSame('class MakerBundle', $meta->getClassDeclaration());
     }
 
-    public function testGetClassDeclarationWithExtends(): void
+    public function testGetClassDeclarationWithExtends()
     {
         $meta = ClassData::create(class: MakerBundle::class, extendsClass: MakerTestKernel::class);
 
         self::assertSame('final class MakerBundle extends MakerTestKernel', $meta->getClassDeclaration());
     }
 
     /** @dataProvider suffixDataProvider */
-    public function testSuffix(?string $suffix, string $expectedResult): void
+    public function testSuffix(?string $suffix, string $expectedResult)
     {
         $data = ClassData::create(class: MakerBundle::class, suffix: $suffix);
 
@@ -72,7 +72,7 @@ public function suffixDataProvider(): \Generator
     }
 
     /** @dataProvider namespaceDataProvider */
-    public function testNamespace(string $class, ?string $rootNamespace, string $expectedNamespace, string $expectedFullClassName): void
+    public function testNamespace(string $class, ?string $rootNamespace, string $expectedNamespace, string $expectedFullClassName)
     {
         $class = ClassData::create($class);
 
@@ -92,7 +92,7 @@ public function namespaceDataProvider(): \Generator
         yield ['Controller\MyController', 'Maker', 'Maker\Controller', 'Maker\Controller\MyController'];
     }
 
-    public function testGetClassName(): void
+    public function testGetClassName()
     {
         $class = ClassData::create(class: 'Controller\\Foo', suffix: 'Controller');
         self::assertSame('FooController', $class->getClassName());
@@ -102,7 +102,7 @@ public function testGetClassName(): void
         self::assertSame('App\Controller\FooController', $class->getFullClassName());
     }
 
-    public function testGetClassNameRelativeNamespace(): void
+    public function testGetClassNameRelativeNamespace()
     {
         $class = ClassData::create(class: 'Controller\\Admin\\Foo', suffix: 'Controller');
         self::assertSame('FooController', $class->getClassName());
@@ -112,7 +112,7 @@ public function testGetClassNameRelativeNamespace(): void
         self::assertSame('App\Controller\Admin\FooController', $class->getFullClassName());
     }
 
-    public function testGetClassNameWithAbsoluteNamespace(): void
+    public function testGetClassNameWithAbsoluteNamespace()
     {
         $class = ClassData::create(class: '\\Foo\\Bar\\Admin\\Baz', suffix: 'Controller');
         self::assertSame('BazController', $class->getClassName());
@@ -121,7 +121,7 @@ public function testGetClassNameWithAbsoluteNamespace(): void
     }
 
     /** @dataProvider fullClassNameProvider */
-    public function testGetFullClassName(string $class, ?string $rootNamespace, bool $withoutRootNamespace, bool $withoutSuffix, string $expectedFullClassName): void
+    public function testGetFullClassName(string $class, ?string $rootNamespace, bool $withoutRootNamespace, bool $withoutSuffix, string $expectedFullClassName)
     {
         $class = ClassData::create($class, suffix: 'Controller');