[dx] require >= PHPUnit 9.6, update phpunit schema, deprecate skipOnSymfony7() #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
added
Minor
jrushlow
changed the title
jrushlow
commented
Jan 26, 2024
| // @legacy - MakeEntity uses ux-turbo-mercure (archived), it needs to use ux-turbo (mercure built in) for Symfony 7.0 | ||
| if ('7.0.x-dev' === $_SERVER['SYMFONY_VERSION']) { | ||
| return $this->createMakerTest() | ||
| ->skipTest('symfony/ux-turbo-mercure is not supported on Symfony 7.') |
There was a problem hiding this comment.
Chicken or the egg... MakeEntity needs to be refactored to use ux-turbo and at first glance doesn't appear to be a "1 for 1" swap with ux-turbo-mercure. To keep the entire test suite from blowing up due to a deprecation - this skip conditional was moved here for now.
weaverryan
requested changes
Feb 1, 2024
composer.json
Outdated
| @@ -30,6 +30,7 @@ | |||
| "composer/semver": "^3.0", | |||
| "doctrine/doctrine-bundle": "^2.5.0", | |||
| "doctrine/orm": "^2.10.0", | |||
| "phpunit/phpunit": "^9.6", | |||
There was a problem hiding this comment.
Does phpunit-bridge read / respect this? We run vendor/bin/simple-phpunit, which downloads its own phpunit. Does this signal to download 9.6? I thought the version was done with an env var.
There was a problem hiding this comment.
good catch! added the SYMFONY_PHPUNIT_VERSION with 9.6 to phpunit.xml.dist instead.... simple-phpunit picks up on that locally and on ci when doing the install.
| // @legacy - MakeEntity uses ux-turbo-mercure (archived), it needs to use ux-turbo (mercure built in) for Symfony 7.0 | ||
| if ('7.0.x-dev' === $_SERVER['SYMFONY_VERSION']) { | ||
| return $this->createMakerTest() | ||
| ->skipTest('symfony/ux-turbo-mercure is not supported on Symfony 7.') |
jrushlow
added
Status: Reviewed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecates
MakerTestDetails::skipOnSymfony7()methods that were meant to be used internally.add ability to skip tests locally (e.g. mercure tests can be skipped by setting
MAKER_SKIP_MERCURE_TESTtotrueinphpunit.xml. Previously that var had to be set in the$_SERVERsuper global.) This plays into Windows tests on GitHub actions.fix outdated / deprecated
phpunit.xml.distschema / attributesrequire PHPUnit 9.6+ in tests (Only have to worry about 1 phpunit.xml schema. )
adds a
MakerTestDetails::skipTest()method & logic to replace the now deprecatedskipOnSymfony7()methods. Ideally, we'll keep the new method for future use even if we're not using it now.skipTest()is marked@internalfor the time being.