Compatibility to dependency php parser v5 #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drieschel
force-pushed
the
allow_php_parser_5
branch
from
a3feccf to
47ff1fc
Compare
drieschel
force-pushed
the
allow_php_parser_5
branch
2 times, most recently
from
3762524 to
790945d
Compare
drieschel
changed the title
drieschel
changed the title
drieschel
changed the title
weaverryan
reviewed
Jan 10, 2024
drieschel
force-pushed
the
allow_php_parser_5
branch
from
790945d to
503e7a1
Compare
weaverryan
approved these changes
Jan 10, 2024
jrushlow
approved these changes
Jan 23, 2024
|
@weaverryan Can we please release this change? 🙏🏻 |
Merged
done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for dependency
nikic/php-parserv5.Not sure if it works without additional changes, lets see if the tests will succeed.
Edit: Looks like a new major (or at least minor) version is required in order to make it compatible with v5, because v4 will not be compatible anymore.
Edit2: I did some refactoring and now it is working with v4 and v5.