Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:entity] Fix error while making blob in entity #1176

Merged
merged 2 commits into from
Sep 22, 2022
Merged

[make:entity] Fix error while making blob in entity #1176

merged 2 commits into from
Sep 22, 2022

Conversation

mdoutreluingne
Copy link
Contributor

Fixes #1174

@mdoutreluingne mdoutreluingne mentioned this pull request Sep 10, 2022
Closed
@weaverryan
Copy link
Member

This looks good - but tests are red. If you rebase with main, that might help - @jrushlow fixed most of the test suite a few days ago.

@mdoutreluingne
Copy link
Contributor Author

Rebase done. It seems that my test is not working, I will look at it tomorrow to try to correct it.

@mdoutreluingne
Copy link
Contributor Author

It seems that the red tests are not related to my PR. However, I want to correct the tests but I can't, help would be welcome :)

weaverryan
weaverryan approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some upstream changes, once again, broke the tests (MakerBundle's test suite, by design, is sensitive to recipe changes... which is great, but also annoying). We'll put a PR soon to fix that. But this is ready to go 👍

@weaverryan weaverryan added the Status: Reviewed Has been reviewed by a maintainer label Sep 20, 2022
@jrushlow
Copy link
Collaborator

@mdoutreluingne I just merged in a few CI fixes. Can you rebase this PR?

@jrushlow jrushlow added the Bug Bug Fix label Sep 20, 2022
@mdoutreluingne
Copy link
Contributor Author

Rebase done. Unfortunately the tests are always red with the same message Failed asserting that two strings are identical.. I also re-tested locally by deleting my changes (to see if it is related to my PR) but the tests are also red.

@jrushlow
Copy link
Collaborator

Thanks @mdoutreluingne - I'm going to push a commit or two to this PR to get the passing tests. It looks like we'll need to add another test fixture to handle the change...

No need to push any additional changes to the PR.

@jrushlow jrushlow changed the title Fix error while making blob in entity [make:entity] Fix error while making blob in entity Sep 22, 2022
jrushlow
jrushlow approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdoutreluingne for the fix!

@jrushlow jrushlow merged commit 026b814 into symfony:main Sep 22, 2022
@mdoutreluingne mdoutreluingne deleted the fix_1174 branch September 22, 2022 17:01
@jrushlow jrushlow mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while making blob in entity
3 participants
@mdoutreluingne @weaverryan @jrushlow