Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verify-email] Coding standards - Twig #1031

Merged
merged 1 commit into from
Feb 16, 2022
Merged

[verify-email] Coding standards - Twig #1031

merged 1 commit into from
Feb 16, 2022

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Dec 2, 2021

Hi,
I changed the case to be like the standard coding:
https://twig.symfony.com/doc/3.x/coding_standards.html

@seb-jean seb-jean changed the title [reset-password] Coding standards [verify-email] Coding standards Dec 2, 2021
@seb-jean seb-jean changed the title [verify-email] Coding standards [verify-email] Coding standards - Twig Dec 2, 2021
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The changes look good, could you rebase this PR please. We've fixed a number of broken tests since you've opened the PR. Thanks in advanced.

Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @seb-jean!

@jrushlow jrushlow added the Status: Reviewed Has been reviewed by a maintainer label Feb 15, 2022
@jrushlow jrushlow mentioned this pull request Feb 15, 2022
@weaverryan
Copy link
Member

And thanks again @seb-jean!

@weaverryan weaverryan merged commit 112ed50 into symfony:main Feb 16, 2022
weaverryan added a commit that referenced this pull request Feb 16, 2022
This PR was merged into the 1.0-dev branch.

Discussion
----------

[release] prep v1.37.0

# RELEASE

Hi Makers!

This release handles several bug fixes within MakerBundle and adds support for translating ResetPasswordBundle Exception messages, using constants instead of strings with `make:voter`, improved types for `Collection` getter methods in Entities, and support for attributes in `make:registration`!

Diff: v1.36.4...v1.37.0

Happy making!

---

# CHANGELOG

## [v1.37.0](https://github.com/symfony/maker-bundle/releases/tag/v1.37.0)

*February 15th, 2022*

### Feature

- [#1062](#1062) - [MakeRegistration] add support for verify email attributes - *`@jrushlow`*
- [#1059](#1059) - [make:reset-password] Translate exception reasons provided by ResetPasswordBundle - *`@bocharsky`-bw*
- [#1057](#1057) - [Voter] Refactor attributes - *`@mdoutreluingne`*
- [#1040](#1040) - [make:entity] Chaing getter PHPDoc return type on Collection - *`@mehdibo`*

### Bug Fix

- [#1060](#1060) - Add missing Passport use statement - *`@bocharsky`-bw*
- [#1032](#1032) - [reset-password] Coding standards - Twig - *`@seb`-jean*
- [#1031](#1031) - [verify-email] Coding standards - Twig - *`@seb`-jean*
- [#1027](#1027) - Fixing wrong messaging in make:auth about checking password in final steps - *`@weaverryan`*
- [#985](#985) - [make:auth] fix security controller attributes - *`@jrushlow`*

Commits
-------

52063a9 [release] prep v1.37.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants