[Tests] Move expectException closer to the place of the expectation t…

…o avoid false positives
symfony · Oct 31, 2023 · c1108eb · c1108eb
1 parent af6cf42
commit c1108eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/Tests/PackagesTest.php b/Tests/PackagesTest.php
@@ -61,14 +61,12 @@ public function testGetUrl()
     public function testNoDefaultPackage()
     {
         $this->expectException(LogicException::class);
-        $packages = new Packages();
-        $packages->getPackage();
+        (new Packages())->getPackage();
     }
 
     public function testUndefinedPackage()
     {
         $this->expectException(InvalidArgumentException::class);
-        $packages = new Packages();
-        $packages->getPackage('a');
+        (new Packages())->getPackage('a');
     }
 }
diff --git a/Tests/UrlPackageTest.php b/Tests/UrlPackageTest.php
@@ -110,7 +110,7 @@ public function testNoBaseUrls()
     /**
      * @dataProvider getWrongBaseUrlConfig
      */
-    public function testWrongBaseUrl($baseUrls)
+    public function testWrongBaseUrl(string $baseUrls)
     {
         $this->expectException(InvalidArgumentException::class);
         new UrlPackage($baseUrls, new EmptyVersionStrategy());