-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adds default configuration and styling for SonataAdmin frontend link #276
[WIP] Adds default configuration and styling for SonataAdmin frontend link #276
Conversation
@@ -164,6 +164,9 @@ sonata_admin: | |||
cmf_routing.admin_extension.route_referrers: | |||
implements: | |||
- Symfony\Cmf\Component\Routing\RouteReferrersInterface | |||
cmf_routing.admin_extension.frontend_link: | |||
implements: | |||
- Symfony\Cmf\Component\Routing\RouteReferrersReadInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you support Route objects too, we could enable the extension for them as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in ac8a942
i merged the PR on RoutingBundle. |
To get the custom CSS working, I had to make some changes in symfony-cmf/routing-bundle#274 again. Almost impossible to identify (and style) the frontend-link button without a specific CSS class. I'm not really a Frontend-Ninja, but it works now... /cc @dbu |
looks good to me. can you composer update symfony-cmf/routing-bundle to get the extension? i just tagged 1.3.1 of the RoutingBundle. |
Seems that |
ah, the sandbox depends on routing-bundle through symfony-cmf/symfony-cmf and also symfony-cmf/routing-auto-bundle. can you try to |
@dbu Changed. Thing to do was Bot now there is a broken test. I tried to investigate, but i've no idea what this is about:
EDIT: Just found out, that it is the cmf_routing.admin_extension.frontend_link:
implements:
- Symfony\Cmf\Component\Routing\RouteReferrersReadInterface
#extends:
#- Symfony\Component\Routing\Route EDIT: Fixed in symfony-cmf/routing-bundle#275 |
@frne can you please do the composer update symfony-cmf/routing-bundle one more time to fix things? and then squash your commits into one? |
3f67832
to
425e713
Compare
@dbu done. |
[WIP] Adds default configuration and styling for SonataAdmin frontend link
awesome, thanks a lot! |
@frne btw, you could write to the symfony-cmf-devs list if you want, to tell you added this feature and say who you are. no requirement but you should get full credit for that one ;-) |
This is WIP because symfony-cmf/routing-bundle#273 must be merged before.