-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatoRs Submission #47
Conversation
Please add these instructions to your contribution guide. You can see out functions here: https://nataliepatten.github.io/gatoRs/reference/index.html I would also suggest referring to Table 1 in our publication.
|
Great. I'm looking for two reviewers: @jamiemkass, @hannahlowens, @luismurao, @MayaGueguen, @AMBarbosa, @gepinillab, @azizka, @marlonecobos, @babaknaimi, @ecospat, @danlwarren, @sgvignali, @sjevelazco, @damariszurell, @mlammens, @IanOndo, @rvalavi, @AndreaSanchezTapia, @codelab3 are you available? Please have a look at the reviewing guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this submission, @mgaynor1! I flagged two inconsistencies with your submission details, and based on an admittedly quick reading of your paper, suggest one "yes" that is currently a "no".
inst/extdata/packages/gatoRs.yaml
Outdated
pred_inspect: no | ||
post_processing: no | ||
gui: yes | ||
metadata: no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might actually be a yes, unless I misunderstand citation_bellow()--I'd call citations metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! Thanks for catching this!
inst/extdata/packages/gatoRs.yaml
Outdated
mod_evaluate: no | ||
mod_multispecies: no | ||
mod_mechanistic: no | ||
pred_general: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent with submission table. Please change to "no".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected!
inst/extdata/packages/gatoRs.yaml
Outdated
mod_fit: no | ||
mod_tuning: no | ||
mod_ensemble: no | ||
mod_stack: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent with submission table. Please change to "no".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected, thanks for catching this too!
@hannahlowens thanks. @mgaynor1 please fix or answer comments for acceptance. |
@sylvainschmitt corrected based on @hannahlowens comments. |
Thanks for your submission. Everything looks fine in the latest version except "gui". This typically refers to a separate GUI with buttons, forms, etc. that can be used to implement some of the functionality of your package. It seems that |
updated! |
Submission of gatoRs which streamlines downloading and cleaning biodiversity data from Integrated Digitized Biocollections (iDigBio) and the Global Biodiversity Information Facility (GBIF).