Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatoRs Submission #47

Merged
merged 3 commits into from
Dec 9, 2024
Merged

gatoRs Submission #47

merged 3 commits into from
Dec 9, 2024

Conversation

mgaynor1
Copy link

@mgaynor1 mgaynor1 commented Dec 2, 2024

Submission of gatoRs which streamlines downloading and cleaning biodiversity data from Integrated Digitized Biocollections (iDigBio) and the Global Biodiversity Information Facility (GBIF).

@sylvainschmitt
Copy link
Owner

@mgaynor1 , thanks for the submission. Please can you further describe the reason to answer yes for the field you did linking to your package's functionalities? See for instance #35 .

@mgaynor1
Copy link
Author

mgaynor1 commented Dec 3, 2024

Please add these instructions to your contribution guide.

You can see out functions here: https://nataliepatten.github.io/gatoRs/reference/index.html

I would also suggest referring to Table 1 in our publication.

flag Response Comment
occ_acquisition yes See function gator_download().
occ_cleaning yes The package contains some helper functions for preparing biodiversity data including functions for identifying missing information, removing missing or redacted records, merging datasets, removing duplicate records, taxonomic harmonization, locality-based cleaning, basis cleaning, spatial thinning, and more. See functions under "Clean Data"
data_integration no Not included.
env_collinearity no Not included.
env_process no Not included.
bias yes Spatially thinning of occurrences included. See thin_points() and one_point_per_pixel()
study_region no Not included.
backg_sample no Not included.
data_partitioning no Not included.
mod_fit no Not included.
mod_tuning no Not included.
mod_ensemble no Not included.
mod_stack no Not included.
mod_evaluate no Not included.
mod_multispecies no Not included.
mod_mechanistic no Not included.
pred_general no Not included.
pred_extrapolation no Not included.
limitingpred_inspect no Not included.
post_processing no Not included.
gui yes See process_flagged()
metadata no Not included.

@sylvainschmitt
Copy link
Owner

Copy link
Collaborator

@hannahlowens hannahlowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this submission, @mgaynor1! I flagged two inconsistencies with your submission details, and based on an admittedly quick reading of your paper, suggest one "yes" that is currently a "no".

pred_inspect: no
post_processing: no
gui: yes
metadata: no
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might actually be a yes, unless I misunderstand citation_bellow()--I'd call citations metadata.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Thanks for catching this!

mod_evaluate: no
mod_multispecies: no
mod_mechanistic: no
pred_general: yes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent with submission table. Please change to "no".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected!

mod_fit: no
mod_tuning: no
mod_ensemble: no
mod_stack: yes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent with submission table. Please change to "no".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected, thanks for catching this too!

@sylvainschmitt
Copy link
Owner

@hannahlowens thanks. @mgaynor1 please fix or answer comments for acceptance.

@mgaynor1
Copy link
Author

mgaynor1 commented Dec 5, 2024

@sylvainschmitt corrected based on @hannahlowens comments.

@jamiemkass
Copy link
Collaborator

Thanks for your submission. Everything looks fine in the latest version except "gui". This typically refers to a separate GUI with buttons, forms, etc. that can be used to implement some of the functionality of your package. It seems that process_flagged() runs a leaflet map, which I would not call a "GUI". It is certainly interactive though.

@mgaynor1
Copy link
Author

mgaynor1 commented Dec 6, 2024

updated!

@sylvainschmitt sylvainschmitt merged commit dbd84b9 into sylvainschmitt:main Dec 9, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants