Allow user to enable rainbow-identifiers-mode without making it default #6192
Conversation
When you add the colors layer with rainbow-identifiers enabled, currently Spacemacs always adds rainbow-identifiers-mode to the prog-mode-hook, essentially making it the default. This adds a new variable, colors-rainbow-identifiers-add-hook, which controls this behavior. Defaults to t; if set to nil, this hook is not created. Example usage has also been added to the README.org for the colors layer.
|
Can't people who want this just use |
|
That's also a perfectly fine solution; I made this change originally because creating the hook automatically seemed somewhat rude, but that's admittedly a very "feely" justification. If no one else has any better reason for wanting this feature, I'll happily close the pull request. |
|
I see your point, we have this kind of control on flycheck and some other layers. What I would do is to remove this line https://github.com/syl20bnr/spacemacs/blob/develop/layers/+themes/colors/packages.el#L46 Can you update your PR with the above modifications ? |
Per syl20bnr's comment on PR 6192, the package should always be installed with the colors layer, but only hooked into prog-mode when the variable is active. Renamed the variable colors-enable-rainbow-identifiers-by-default to clarify this, and modified the documentation.
|
Okay, that's done. |
|
Thank you ! 👍 In the end I removed this variable for a new variable |
When you add the colors layer with the
rainbow-identifierspackage enabled (colors-enable-rainbow-identifiersvariable set tot), currently the layer always adds'rainbow-identifiers-modeto theprog-mode-hook, essentially making it the default. This PR adds a new variable,colors-rainbow-identifiers-add-hook, which controls this behavior. Defaults tot(previous behavior); if set tonil, this hook is not created. This allows a user to installrainbow-identifiersthrough the preexisting layer, still getting theSPC t C itoggle binding, without turning it on by default.Example usage has also been added to the README.org for the colors layer.
I've been running with this for a few months now, but just now got around to prettying it up for release; let me know if there's any style/naming issues.