-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove structured-haskell-mode #5078
Conversation
I believe that some people would not like this decision, but again, if someone has a good solution for this problem - PRs are warmly welcome. I think that shm is incredibly great thing, it's just doesn't work with vim editing style as good as it works with emacs editing style. In case Chris Done reading this - thanks for shm - it makes me happy when I code in Haskell. :D |
👍 |
We should mention shm in the README and explain our motivation behind the removal so people are aware of it and may try to fix it. |
Why not conditionally install it based on editing style? Rather than remove it altogether. |
Also this is against |
👍 after trying it out multiple times already. Until there's evil support, it's probably better to just install it with additional packages. |
Just wow. Haha. My bad, will redo (in several hours). :-P
Sure we can install it only for emacs editing style (and even not for hybrid). There are actually 3 (or 2) configs that will be common for everyone. And then comes some per-person configs. Also, shm is not supported for all themes. For example, I asked nashamri to update Spacemacs theme so it supports shm highlights. But from my experience only few themes has this support - in other themes it would look like broken thing. So I think that shm configs are personal. I will just add notes about what everyone wants. How does it sound to you, @robbyoconnor?
Ok, I'll write up some notes. |
Closing this PR in order to make @robbyoconnor happy :) P. S. will reopen it very soon. |
@d12frosted You don't contribute enough often to avoid this kind of mistake it seems 😉 |
@StreakyCobra yeah, it seems so - hope to fix it soon :) |
Just as the title says - by this commit we remove shm. The main reason is that shm doesn't play well with vim editing style and causing more problems that are not so easily fixed. But still, it's very easy to add it to personal configs if you are using emacs editing style.
Related issues: #5026, #1048 and #3171(this one has more explanations).
P. S. Do I need to add anything about how to enable shm to haskell layer readme? With warning 'use it for your own risk and preferably with emacs editing style' :)
P. P. S. @syl20bnr thanks for the green light :)