Add seeing is believing layer

[brandoncc]

No description provided.

[TheBB]

Sorry, but this use-package call isn't very up to scratch. :init runs before loading and :config runs after loading, but since you load the package in :init, everything ends up running at the same time, causing this package to be loaded on startup. Remove the require and make the keybindings in :init instead of :config.

[nixmaniack]

I believe seeing-is-believing belongs to ruby layer instead separate layer.

[brandoncc]

@TheBB Thank you for the feedback. I have a better understanding of use-package now. I had not used it at all before I got this working, and the only way I could make it work was to do it the way I had it. require is no longer necessary now that I am using only init. I did not understand why it was necessary, but that is precisely because of my defer.

@nixmaniack I didn't put it there because it is a tool that not everybody uses, should I still put it there? I should put some sort of condition on it to only init if the executable is present I assume? If so, could you point me in the right direction to learn about that and where exactly the condition should be?

[nixmaniack]

@brandoncc Not sure about the best way, others should correct me.

You should look at ruby-layer's packages.el and how each package is initialised. use-package has conditional loading which you can make use of with (executable-find "seeing-is-believing") for loading only if binary is found.

[brandoncc]

Ah, I did read that conditional loading section but I didn't see anything
about an executable (I still don't but I will try it with the code you
provided). I was using the ruby layer as my example when I was building it
actually, I just wasn't looking at the most relevant section I guess.
Thanks for the help.

On Sat, Oct 17, 2015 at 9:28 AM, Muneeb Shaikh notifications@github.com
wrote:

@brandoncc https://github.com/brandoncc Not sure about the best way,
others should correct me.

You should look at ruby-layer's packages.el and how each package is
initialised. use-package has conditional loading
https://github.com/jwiegley/use-package#conditional-loading which you
can make use of with (executable-find "seeing-is-believing") for loading
only if binary is found.

—
Reply to this email directly or view it on GitHub
#3436 (comment).

[brandoncc]

@TheBB I believe I have addressed the issues. Please take a look.

[dcluna]

@brandoncc 👍 This is cool

[dcluna]

Lisp convention does not allow trailing parentheses like this one. Can you move it to the end of the previous line?

[brandoncc]

Fixed, but the PR is out of date and can't be merged. I don't use spacemacs anymore so I won't be fixing that unfortunately. Anybody else is welcome to.

[brandoncc]

@TheBB I fixed the merge issues on this.

[dennissivia]

I am happy somebody is already working on this. Would be great to have this being part of spacemacs,
especially since I believe it is still not an elpa package.

[Compro-Prasad]

According to comment by @brandoncc what should be done this PR @sdwolfz @syl20bnr ?

[syl20bnr]

Need to find other key bindings, these one are reserved for REPL interactions.
Can those two functions be unified together into a toggle ?

[Compro-Prasad]

This ain't changing.

[brandoncc]

I haven't used spacemacs in quite a while. Someone else is welcome to find better bindings, but I doubt I will ever do it.

[sdwolfz]

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!

I rebased with latest develop and updated the code in 6302748. For keybindings I used SPC m @ since the @ kind of looks like an eye 😺. At first this tool did not seem like it would be very usefully, more like a gimmick, but it hit me that this can be used effectively for writing data processing scripts and it's cleaner that using a shell.

Cherry-picked into develop branch, you can safely delete your branch.