Update code to show magit buffers in full screen #3319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for such a fast PR. I think all buffers were full-screen. Well, except when you press |
With my PR, the commit is shown full screen too. I think I know why, but lets see if the discussion in Magit will provide a better solution. |
bmag
changed the title
|
Well, I am ok with both, actually. So yeah, let's hear what others think. |
kostya-sh
referenced
this pull request
in magit/magit
Oct 13, 2015
Use low-level `display-buffer' instead of high-level buffer switching functions. In combination with other changes described below, this gives users complete control over how buffers are to be displayed, without having to fight against hard-coded defaults. Instead of hard-coding the rules that govern how windows are selected to display certain buffers, define them in one place. The existing rules are collected in the new function `magit-display-buffer-traditional'. That function is the default value of the new option `magit-display-buffer-function', which specifies the function used by `magit-display-buffer' to actually display the buffer. All Magit buffers are displayed using `magit-display-buffer', which is called by `magit-mode-setup' and `magit-process-buffer'. Together these two functions are responsible for the creation of each and every Magit buffer. `magit-display-buffer' should never called directly by anything else. (Popup buffers are not Magit buffers, their major-mode does not derived from `magit-mode'.) Unlike `display-buffer', `magit-display-buffer' also selects the window, unless the new variable `magit-display-buffer-noselect' is let-bound to a non-nil value. This variable is only intended for special cases. Two options, and therefore quick ways of customizing the behavior, fall victim to this change: `magit-status-buffer-switch-function' and `magit-diff-switch-buffer-function'. We cannot preserve these options and use them in `magit-display-buffer-traditional' because they were used to specify arbitrary high-level buffer switching functions, which we cannot simply map to low-level display actions.
|
Bump. Any update on this? |
|
I was waiting to see if anyone else had something to say in the other discussion, but it doesn't seem so. I'll work on an improved solution sometime before Sunday. |
|
Ah cool. Thanks for the heads up. |
bmag
force-pushed
the
update-magit-fullscreen
branch
from
7363091
to
ade75ef
Compare
bmag
changed the title
|
@d12frosted this PR is ready now |
|
Sweet. Thanks for the update. |
|
Thanks! Cherry-picked in develop. You can safely delete your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in Magit removed
magit-status-buffer-switch-functionand introducedmagit-display-buffer-function, causing our configuration for full screen Magit buffers to break. This PR updates the relevant configuration.There is some discussion here
I don't remember if the old configuration opened all
magit-modederived buffers (e.g. including log buffers and diff buffers) in full screen or just the status buffer. The new configuration affects allmagit-modederived buffers.cc @d12frosted