Add Twitter layer #2837
Closed
Add Twitter layer #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CestDiego
force-pushed
the
twittering-mode
branch
from
3981f3e
to
4884206
Compare
CestDiego
force-pushed
the
twittering-mode
branch
from
4884206
to
175ffe6
Compare
|
@syl20bnr I rebased this. |
|
Can you resize the logo to 200px height ? |
|
Look forward to seeing this merged! @CestDiego As @syl20bnr mentioned can you please resize the logo to 200px, and also use the new twitter logo instead of the old one? (See here) |
CestDiego
force-pushed
the
twittering-mode
branch
from
175ffe6
to
9720d1d
Compare
|
It has been rebased and changed to 200px |
|
@CestDiego Fantastic. @syl20bnr Can we have this merged please? 😃 |
|
@CestDiego You probably have to adapt the README to the new template (like |
CestDiego
force-pushed
the
twittering-mode
branch
from
9720d1d
to
ebed891
Compare
CestDiego
force-pushed
the
twittering-mode
branch
from
ebed891
to
550a77e
Compare
|
@StreakyCobra I modified the tag :) |
|
+1 |
|
+1 |
|
This will need a few keybindings since SPC is used by twittering-mode. See also #5304. |
|
Cherry-picked into develop branch !! Thank you 👍 |
|
Awesome! I can remove my layer now. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.