Add (optional) ebib support to bibtex layer #14876
Conversation
dalanicolai
force-pushed
the
add-ebib-support-to-bibtex-layer
branch
2 times, most recently
from
ca636cf to
cc286e4
Compare
dalanicolai
force-pushed
the
add-ebib-support-to-bibtex-layer
branch
from
cc286e4 to
61a9e63
Compare
layers/+lang/bibtex/packages.el
Outdated
| (evilified-state-evilify-map ebib-log-mode-map | ||
| :mode ebib-log-mode) | ||
|
|
||
| (use-package ebib-biblio |
There was a problem hiding this comment.
ebib-biblio is not a package. it's a feature of ebib.
So you should have :after (biblio) in (use-package ebib) instead.
Then in its :config, add ebib-biblio-selection-import key binding.
There was a problem hiding this comment.
ebib-biblio really has to get loaded separately (see here). But indeed I could use the :after (biblio) in (use-package ebib) and then (require ebib-biblio) in the :config. But I think it does not make much of a difference (or maybe does it?)
There was a problem hiding this comment.
I think the upstream author is abusing use-package.
For example, Spacemacs has defined a core-configuration-layer feature. You can try (use-package core-configuration-layer), since it's found in load path, it will succeed.
Basically, any feature found in load path can be declared as a package via use-package. But it's really not a package.
There was a problem hiding this comment.
Your argument for/perspective on using the appropriate 'labels' for the various cases, makes sense. But it seems that, practically, it should not make much of a difference as use-package for this case simply expands to require (see here). But it is fine for me to 'adapt' the 'terminology'.
dalanicolai
force-pushed
the
add-ebib-support-to-bibtex-layer
branch
2 times, most recently
from
7b08e87 to
cf1e33d
Compare
|
I have removed the comment about migration to JabRef because its browser extension turns out not to be so good (I will probably stay with jabref myself, but don't really explicitly recommend it at the moment. It still is quite nice though) |
dalanicolai
force-pushed
the
add-ebib-support-to-bibtex-layer
branch
from
81fb4e6 to
7877b99
Compare
This commit moves the eww keybindings to make them available for ebib provided by the bibtex layer
dalanicolai
force-pushed
the
add-ebib-support-to-bibtex-layer
branch
from
7877b99 to
fdee20f
Compare
|
@dalanicolai |
|
As far as I remember, this PR was ready to get merged, otherwise I would have made the changes already. Thanks again! |
|
merged. thanks for your contributions |
Ebib is a nice new Emacs application to manage bibtex references.This PR adds optional (via a layer variable) installation and configuration of the ebib package.
Currently, it only adds the most basic configurations to make it fit into Spacemacs. Additional configurations are welcome but they are not essential.