When evil-search-module is evil-search then SPC s c doesn't work

[jonathanj]

It would be nice if SPC s c worked for evil-search mode too, I prefer evil-search since it's a lot like Vim's search rather than Emacs' isearch.

For some reason search highlights also look different when evil-search is the selected search module, I don't understand why.

[tuhdo]

Indeed when setting evil-search-module to evil-search, it can no longer clear highlighting or activate highlighting. You should report upstream.

[tuhdo]

@jonathanj this is unrelated to this issue but related to the issue with searching with hgrep buffer earlier. Actually you can use these key bindings to easily navigate the buffer and it won't conflict with evil-mode:

• C-<down>: go to next match and open the match.
• C-<up>: go to previous match and open the match.
• M-<down>: go to next match without opening the match.
• M-<up>: go to next match without opening the match.

[tuhdo]

@jonathanj the deleting windows issue has just been fixed upstream few minutes ago. Wait a few hours and update Helm again, you won't have that error anymore.

[tuhdo]

@jonathanj btw when you want to search for actual key bindings of a major mode, use SPC ?. It will display a list of available key bindings in current major mode and you can play easily narrow to some commands or key bindings you care about by simply typing some pattern. You would find out these key bindings earlier if you had used SPC ?. And press C-z (or Tab in next release) to read the documentation of each command. It's really amazing.

[StreakyCobra]

This is an old issue that seems to have been solved upstream, closing it then, but feel free to open a new issue in case of troubles ☺️

[jonathanj]

This still doesn't seem to be working for me (I updated all my packages before testing this). The upstream bug originally referenced is still open and there has been no reply from the author to my question.

There also don't appear to be any commits upstream that would have resolved this. Do you mind explaining why you think the issue has been solved? Did I miss something?

[StreakyCobra]

Sorry, I'm doing a cleanup and I may be a little bit to prompt to close 6+ months issues without activity that I can't reproduce. As I failed reproducing it, I thought it was solved. I probably have missed a step.

As you say it's a valid issue, I reopen it ☺️ Sorry for the annoyance.

[jonathanj]

@StreakyCobra I think the trick to reproducing it is in my comment on the upstream issue. You need to restart emacs after flipping that search switch otherwise you're still using the other search mode.

[StreakyCobra]

Indeed, putting (setq evil-search-module 'evil-search) in user-config and restarting allows to reproduce it.

[StreakyCobra]

PR pending #5727

[d12frosted]

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.

[agzam]

For me it mostly works, I found when it doesn't:

When you do g d evil-goto-definition it highlights it, and then SPC s c does not clear it. (Unless you set: (setq evil-search-module 'isearch)

@d12frosted or someone else, can you guys check it out? It seems evil-commands.el uses isearch for goto-definition

[syl20bnr]

Thanks agzam, reopening the issue since there are still some bugs.

[duianto]

Fixed in develop
Clear both / and C-s search highlights with SPC s c #9449

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!