Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include arbitrary files in wheel #191

Closed
wants to merge 1 commit into from

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jan 27, 2022

Fix the include key to apply to sdist format only. Otherwise,
the listed files are added to the top directory of wheel as well
and end up being installed in top-level site-packages directory, e.g.:

 *  FILES:+usr/lib/python3.9/site-packages/CHANGELOG.md
 *  FILES:+usr/lib/python3.9/site-packages/LICENSE
 *  FILES:+usr/lib/python3.9/site-packages/README.md

Fix the include key to apply to sdist format only.  Otherwise,
the listed files are added to the top directory of wheel as well
and end up being installed in top-level site-packages directory, e.g.:

 *  FILES:+usr/lib/python3.9/site-packages/CHANGELOG.md
 *  FILES:+usr/lib/python3.9/site-packages/LICENSE
 *  FILES:+usr/lib/python3.9/site-packages/README.md
@sybrenstuvel
Copy link
Owner

Thanks! This has been merged in 3031bf5

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jul 24, 2022
## Version 4.9 - release 2022-07-20

- Remove debug logging from `rsa/key.py`
  ([#194](sybrenstuvel/python-rsa#194)).
- Remove overlapping slots in `PrivateKey` and `PublicKey`.
  ([#189](sybrenstuvel/python-rsa#189)).
- Do not include CHANGELOG/LICENSE/README.md in wheel
  ([#191](sybrenstuvel/python-rsa#191)).
- Fixed Key Generation Unittest: Public and Private keys are assigned the wrong way around
  ([#188](sybrenstuvel/python-rsa#188)).
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this pull request Nov 11, 2022
- Updated from version 4.8 to 4.9
- Update of rootfile
- Changelog
    ## Version 4.9 - release 2022-07-20
	- Remove debug logging from `rsa/key.py`
	  ([#194](sybrenstuvel/python-rsa#194)).
	- Remove overlapping slots in `PrivateKey` and `PublicKey`.
	  ([#189](sybrenstuvel/python-rsa#189)).
	- Do not include CHANGELOG/LICENSE/README.md in wheel
	  ([#191](sybrenstuvel/python-rsa#191)).
	- Fixed Key Generation Unittest: Public and Private keys are assigned the wrong way around
	  ([#188](sybrenstuvel/python-rsa#188)).

Tested-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants