Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always install dataclasses #30

Closed
sailxjx opened this issue Jan 4, 2022 · 4 comments
Closed

Always install dataclasses #30

sailxjx opened this issue Jan 4, 2022 · 4 comments
Assignees
@sybrenjansen
Labels
bug Something isn't working

Comments

@sailxjx
Copy link

sailxjx commented Jan 4, 2022

When I install mpire from pip install mpire, it will always install dataclasses, even if there is a judgment

This is very confusing and makes this dependency unusable in our library. Please fix this problem as soon as possible.

python version: 3.8.6
mpire version: 2.3.3
@sybrenjansen
Copy link
Owner

@sailxjx that is odd. It seems that installing from source using pip install . behaves differently from pip install mpire. I will investigate this further and will keep you posted.

@sybrenjansen sybrenjansen added the bug Something isn't working label Feb 7, 2022
@sybrenjansen sybrenjansen self-assigned this Feb 7, 2022
@sybrenjansen
Copy link
Owner

I will apply PEP 508, which will hopefully resolve it. This fix will be added to the next release of MPIRE.

sybrenjansen pushed a commit that referenced this issue Feb 21, 2022
Platform specific dependencies are now handled using environment mark…
e197315 
…ers as defined in PEP-508 (fixes #30)
@sailxjx
Copy link
Author

sailxjx commented Feb 22, 2022

Glad to hear it.

@sybrenjansen
Copy link
Owner

Fixed in v2.3.4

@sailxjx sailxjx mentioned this issue Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sybrenjansen sybrenjansen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sailxjx @sybrenjansen