-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidirectional rules #96
Bidirectional rules #96
Conversation
I'm not convinced about the variant with a single rate. For me, when there is only a single rate, intuitively, it means that the reverse rule has an undefined rate. But that's just my intuition. Let's try to get more opinions - maybe @xsafran1 can comment on this? EDIT: Perhaps the safest way to avoid any confusion is NOT to allow a single rate in this case. Can that be implemented? |
I am totally out of context on this, so take it with grain of salt. I understand the intuition like this: #! rules would correspond to undefined rate on reversed rule #! rules How to say that the reverse rule is not even in the model ? Is it possible to have rate of change 0 ? #! rules Maybe I would think that this is the equivalence: `#! rules |
Right, currently it is based on the previous solutions where only one rate was allowed. It is possible to not allow a single rate, but in my opinion single rate means reverse rule has undefined rate makes more sense. |
I have not really thought about that. It is possible to make the rate 0, but I think if the goal is to exclude the reverse rule from the model, just define the rule unidirectionally rather than bidirectionally. This approach directly conveys the absence of a reverse reaction, therefore there's no necessity to employ a rate of 0, which could complicate interpretations. |
Since there are multiple ways to interpret a single rate for bidirectional rules, I would not allow it at all to avoid confusion. |
Bidirectional rules can be now defined only with no rate or two rates. |
Bidirectional rules are allowed. Bidirectional rules can be defined with no specified rate, a single rate that applies to both directions, or two distinct rates, where the first rate applies to the rule in its standard direction and the second rate applies when the rule is applied in reverse.
This is how to define bidirectional rule:
and it is equivalent to these rules:
Tests for bidirectional rules were added in commits a954518 and f648027.
Changes for parsing bidirectional rules were made in commits 2649431 and ee00206.
Close #30