fix: capture exit event if the process is killed

swordev · Oct 3, 2022 · a39a0f4 · a39a0f4
1 parent 39e35c8
commit a39a0f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/blue-mugs-end.md b/.changeset/blue-mugs-end.md
@@ -0,0 +1,5 @@
+---
+"phpstan-vscode": patch
+---
+
+Fix memory leak when the process is killed
diff --git a/src/utils/process.ts b/src/utils/process.ts
@@ -13,6 +13,9 @@ export async function killProcess(p: ChildProcess) {
 export async function waitForClose(childProcess: ChildProcess) {
   return new Promise<number | null>((resolve, reject) => {
     childProcess.on("error", reject);
+    childProcess.on("exit", (exitCode) => {
+      if (childProcess.killed) resolve(exitCode);
+    });
     childProcess.on("close", (exitCode) => resolve(exitCode));
   });
 }