Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send headers by SAPI #3571

Merged
merged 4 commits into from
Aug 19, 2020
Merged

Do not send headers by SAPI #3571

merged 4 commits into from
Aug 19, 2020

Conversation

twose
Copy link
Member

@twose twose commented Aug 14, 2020

CC @sshymko

Please pull this branch to verify if it meets your expectations

Close ##3552

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #3571 into master will increase coverage by 0.63%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3571      +/-   ##
==========================================
+ Coverage   45.41%   46.05%   +0.63%     
==========================================
  Files          76       76              
  Lines       14181    14393     +212     
==========================================
+ Hits         6441     6629     +188     
- Misses       7740     7764      +24     
Impacted Files Coverage Δ
src/os/async_thread.cc 73.33% <0.00%> (+1.33%) ⬆️
src/protocol/base.cc 66.21% <0.00%> (+4.05%) ⬆️
src/coroutine/socket.cc 51.93% <0.00%> (+8.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5813a64...c30cd20. Read the comment docs.

@sshymko
Copy link
Contributor

sshymko commented Aug 14, 2020

@twose
Could you please add the tests headers_sent.phpt and headers_sent_coroutine.phpt from #3552 to the branch?
If both tests pass, that would indicate the changes meet the expectations.

Thanks for your help!

@twose
Copy link
Member Author

twose commented Aug 15, 2020

Passed

@sshymko
Copy link
Contributor

sshymko commented Aug 17, 2020

@twose
The changes look good and the tests do pass. Thanks!
However, the tests have different names which would make it difficult to maintain them.
Submitted #3574 to group the tests together as they're identical just testing coroutines disabled/enabled.

@matyhtf matyhtf merged commit a547e0e into master Aug 19, 2020
@matyhtf matyhtf deleted the sapi_headers branch August 19, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants