Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set options for redis database #166

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Support set options for redis database #166

merged 3 commits into from
Dec 28, 2023

Conversation

sy-records
Copy link
Member

No description provided.

@deminy deminy self-requested a review December 27, 2023 17:30
Copy link
Member

@deminy deminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other Redis options available. Suggesting to update the methods to support other options as well. e.g.,

protected array $options = [];

/**
 * To set/override a configurable option on the Redis object.
 */
public function setOption(int $option, mixed $value): self;

// Alternatively, use the following setter method.

/**
 * To set/override configurable options on the Redis object.
 *
 * @param array<array<int, mixed>> $options
 */
public function setOptions(array $options): self;

@sy-records sy-records requested a review from deminy December 28, 2023 00:14
@sy-records sy-records changed the title Support set prefix for redis database Support set options for redis database Dec 28, 2023
@deminy deminy merged commit 7a973b8 into master Dec 28, 2023
31 checks passed
@sy-records sy-records deleted the prefix branch December 28, 2023 01:42
deminy added a commit that referenced this pull request Dec 28, 2023
cosmetic updates for #166
deminy added a commit to deminy/swoole-src that referenced this pull request Dec 28, 2023
* Use commit swoole/library@2ff30e0 from the master branch.
* With PR swoole/library#166 included.
matyhtf pushed a commit to swoole/swoole-src that referenced this pull request Jan 2, 2024
* bring Swoole Library to latest

* manually adjust order of loaded classes from Swoole Library

* update Swoole Library to latest

using commit swoole/library@4a621c9a from the master branch

* update Swoole Library to latest

* Use commit swoole/library@2ff30e0 from the master branch.
* With PR swoole/library#166 included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants