-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support set options for redis database #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deminy
approved these changes
Dec 27, 2023
deminy
reviewed
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some other Redis options available. Suggesting to update the methods to support other options as well. e.g.,
protected array $options = [];
/**
* To set/override a configurable option on the Redis object.
*/
public function setOption(int $option, mixed $value): self;
// Alternatively, use the following setter method.
/**
* To set/override configurable options on the Redis object.
*
* @param array<array<int, mixed>> $options
*/
public function setOptions(array $options): self;
sy-records
changed the title
Support set prefix for redis database
Support set options for redis database
Dec 28, 2023
deminy
approved these changes
Dec 28, 2023
deminy
added a commit
to deminy/swoole-src
that referenced
this pull request
Dec 28, 2023
* Use commit swoole/library@2ff30e0 from the master branch. * With PR swoole/library#166 included.
matyhtf
pushed a commit
to swoole/swoole-src
that referenced
this pull request
Jan 2, 2024
* bring Swoole Library to latest * manually adjust order of loaded classes from Swoole Library * update Swoole Library to latest using commit swoole/library@4a621c9a from the master branch * update Swoole Library to latest * Use commit swoole/library@2ff30e0 from the master branch. * With PR swoole/library#166 included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.