code quality improvements for PHP 8.1+ using Rector

swoole · May 25, 2024 · 8aa2425 · 8aa2425
1 parent d2fa3b9
commit 8aa2425
Show file tree

Hide file tree

Showing 16 changed files with 151 additions and 151 deletions.
diff --git a/src/core/Coroutine/Barrier.php b/src/core/Coroutine/Barrier.php
@@ -47,7 +47,7 @@ public static function make(): self
     /**
      * @throws Exception
      */
-    public static function wait(Barrier &$barrier, float $timeout = -1)
+    public static function wait(Barrier &$barrier, float $timeout = -1): void
     {
         if ($barrier->cid !== -1) {
             throw new Exception('The barrier is waiting, cannot wait again.');

diff --git a/src/core/Server/Admin.php b/src/core/Server/Admin.php
@@ -67,7 +67,7 @@ class Admin
 
     private static string $accessToken = '';
 
-    public static function init(Server $server)
+    public static function init(Server $server): void
     {
         $accepted_process_types = SWOOLE_SERVER_COMMAND_MASTER |
             SWOOLE_SERVER_COMMAND_MANAGER |

diff --git a/src/core/Server/Helper.php b/src/core/Server/Helper.php
@@ -201,7 +201,7 @@ class Helper
         'admin_server'         => true,
     ];
 
-    public static function checkOptions(array $input_options)
+    public static function checkOptions(array $input_options): void
     {
         $const_options = self::GLOBAL_OPTIONS + self::SERVER_OPTIONS + self::PORT_OPTIONS
             + self::AIO_OPTIONS + self::COROUTINE_OPTIONS + self::HELPER_OPTIONS;
@@ -215,7 +215,7 @@ public static function checkOptions(array $input_options)
         }
     }
 
-    public static function onBeforeStart(Server $server)
+    public static function onBeforeStart(Server $server): void
     {
         if (!empty($server->setting['admin_server'])) {
             Admin::init($server);
@@ -230,7 +230,7 @@ public static function onBeforeShutdown(Server $server): void
         }
     }
 
-    public static function onWorkerStart(Server $server, int $workerId)
+    public static function onWorkerStart(Server $server, int $workerId): void
     {
         if (!empty($server->setting['stats_file']) and $workerId == 0) {
             $interval_ms = empty($server->setting['stats_timer_interval']) ? self::STATS_TIMER_INTERVAL_TIME : intval($server->setting['stats_timer_interval']);
@@ -254,7 +254,7 @@ public static function onWorkerStart(Server $server, int $workerId)
         }
     }
 
-    public static function onWorkerExit(Server $server, int $workerId)
+    public static function onWorkerExit(Server $server, int $workerId): void
     {
         if ($server->stats_timer) {
             Timer::clear($server->stats_timer);