Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require PHP 7.2, switch to Playwright #1047

Merged
merged 10 commits into from
May 10, 2024
Merged

Require PHP 7.2, switch to Playwright #1047

merged 10 commits into from
May 10, 2024

Conversation

swissspidy
Copy link
Owner

  • Require PHP 7.2
  • Hide form if there are zero languages
    • Edge case that happens for example for a fresh new site that's offline and can't download the list of available translations.
  • Switch to Playwright
  • Set up wp-now for quick local testing without Docker

Fixes #861

swissspidy added 5 commits May 8, 2024 10:17
Edge case that happens for example for a fresh new site that's offline and can't download the list of available translations.
@swissspidy swissspidy added this to the 2.3.0 milestone May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (85fc73e) to head (5f60ebb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files           5        5           
  Lines         640      640           
  Branches       39       39           
=======================================
  Hits          601      601           
  Misses         39       39           
Flag Coverage Δ
default 91.55% <ø> (ø)
js 100.00% <ø> (ø)
multisite 91.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissspidy swissspidy merged commit fb875c4 into main May 10, 2024
25 checks passed
@swissspidy swissspidy deleted the fix/861-playwright branch May 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate e2e tests to Playwright
1 participant