Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: Use variant="secondary" instead of isSecondary #1046

Merged
merged 1 commit into from
May 8, 2024

Conversation

Soean
Copy link
Contributor

@Soean Soean commented May 8, 2024

The prop isSecondary is deprecated. We should use variant prop with secondary value instead. See: https://developer.wordpress.org/block-editor/reference-guides/components/button/#props

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (56cf461) to head (00eb3e4).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files           5        5           
  Lines         640      640           
  Branches       39       39           
=======================================
  Hits          601      601           
  Misses         39       39           
Flag Coverage Δ
default 91.55% <ø> (ø)
js 100.00% <ø> (ø)
multisite 91.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissspidy swissspidy added this to the 2.3.0 milestone May 8, 2024
@swissspidy swissspidy merged commit 85fc73e into swissspidy:main May 8, 2024
27 checks passed
@Soean Soean deleted the isSecondary branch May 8, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants