Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, documentation): z-index on header + fake content on header preview #4367

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Dec 30, 2024

…eader preview

@leagrdv leagrdv requested review from a team as code owners December 30, 2024 15:46
@leagrdv leagrdv requested a review from alizedebray December 30, 2024 15:46
@leagrdv leagrdv linked an issue Dec 30, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: eefd43b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 30, 2024

Related Previews

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a max-height to the header story so that it is scrollable? Currently the sticky behavior is still not visible.

packages/documentation/src/utils/fake-content.ts Outdated Show resolved Hide resolved
leagrdv and others added 2 commits December 31, 2024 16:01
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
@leagrdv leagrdv requested a review from alizedebray January 3, 2025 12:58
Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header's behavior is not correct in the story: it is sticky when you start scrolling but disappears afterwards. Can you please investigate this?

The behavior is correct on the full screen preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update header docs to show sticky behaviour
3 participants