-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components, documentation): z-index on header + fake content on header preview #4367
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: eefd43b The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a max-height to the header story so that it is scrollable? Currently the sticky behavior is still not visible.
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
…tps://github.com/swisspost/design-system into 4275-update-header-docs-to-show-sticky-behaviour
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header's behavior is not correct in the story: it is sticky when you start scrolling but disappears afterwards. Can you please investigate this?
The behavior is correct on the full screen preview.
…eader preview