-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(documentation, styles): shadow utilities #4361
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7a05800 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
'shadow': ( | ||
property: box-shadow, | ||
class: shadow, | ||
values: ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the shadows are defined in Figma, they should probably be tokenized: https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=2954-97430&t=6KE9wz1Gn4NJlp6T-4
|
||
const meta: MetaExtended = { | ||
id: '69f2b7e0-827d-4a7a-8580-5ff46dac276d', | ||
title: 'Utilities/Shadow', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the elevations: https://preview-4361--swisspost-design-system-next.netlify.app/?path=/docs/cfdf83ff-efa7-4b3c-ac91-6898c4f88701--docs?
They are the same as the box-shadows, we should only keep one of the two.
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
Quality Gate passedIssues Measures |
No description provided.