-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(documentation, styles): text utilities #4360
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1e6c5fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
@@ -33,10 +33,6 @@ body { | |||
font-family: tokens.get('body-font-family'); | |||
} | |||
|
|||
.font-sans-serif { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a breaking change. If so, can you create a major changeset?
@@ -28,6 +28,15 @@ $position-values: ( | |||
100: 100%, | |||
); | |||
|
|||
$font-family-sans-serif: var(--post-device-font-family-default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device layer tokens (post-device-*
) are not meant to be used directly, it seems like you are missing a utility token here. You can ask @Vandapanda to create it, it would be nice to have tokens for the font weights and line heights as well. They might be useful for the tailwind output anyways.
Co-authored-by: Alizé Debray <33580481+alizedebray@users.noreply.github.com>
Quality Gate passedIssues Measures |
No description provided.