Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: component check list #3511

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

feat: component check list #3511

wants to merge 22 commits into from
+89 −3

Conversation

bashirkarimi
Copy link
Contributor

  • The spaces and size of icon should be checked on each breakpoints.
  • The color of icon should be changed from hardcode value to variable.

@bashirkarimi bashirkarimi linked an issue Sep 9, 2024 that may be closed by this pull request
[component]: Check list #3438
Open
5 tasks
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8a73022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Minor
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-tokens Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-migrations Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 9, 2024 •
edited
Loading

Related Previews

@bashirkarimi bashirkarimi marked this pull request as ready for review September 9, 2024 14:05
@bashirkarimi bashirkarimi requested a review from a team as a code owner September 9, 2024 14:06
@gfellerph gfellerph added needs: discussion There is at least one topic in the pattern descussion meeting about the issue 🏓 dev roundtable To be discussed at the roundtable of esteemed developers labels Sep 9, 2024
@bashirkarimi bashirkarimi marked this pull request as draft September 10, 2024 07:31
@bashirkarimi bashirkarimi marked this pull request as ready for review September 10, 2024 08:54
alizedebray
alizedebray reviewed Sep 12, 2024
View reviewed changes
packages/styles/src/components/list.scss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this file by replacing the bottom and left properties with block-end and inline-start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom and left which have 0 value are reseting the reboot and can not be changed. The rest are changed accordingly.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliverschuerch
Copy link
Contributor

@bashirkarimi create a :after element, place it the same way as the :before element.
Set the background-color of it through the icon and define the icon as a mask-image (there is a mixin for that).

@oliverschuerch oliverschuerch removed the 🏓 dev roundtable To be discussed at the roundtable of esteemed developers label Sep 19, 2024
@bashirkarimi bashirkarimi added needs: discussion There is at least one topic in the pattern descussion meeting about the issue and removed needs: discussion There is at least one topic in the pattern descussion meeting about the issue labels Sep 23, 2024
@bashirkarimi bashirkarimi marked this pull request as draft September 24, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray alizedebray left review comments

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

@gfellerph gfellerph Awaiting requested review from gfellerph

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs: discussion There is at least one topic in the pattern descussion meeting about the issue
Projects
Design System Production Board
Status: 🤬 Dev in review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[component]: Check list
5 participants
@bashirkarimi @swisspost-bot @oliverschuerch @alizedebray @gfellerph